Updated SentenceToSequence #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update SentenceToSequence.java
Update ANounCombiner.java
Before change: * Named entities can't be combined with other phrases because they are replaced by URIs in the question * Hawk add query fragments based on the retrieved named entities and phrases from getLanguageToNamedEntites() & getLanguageToNounPhrases() After change: * Named entities are identified BUT not replaced by URIs in the question * Combination is done for all question phrases including NEs * all combined phrases are added to getLanguageToNounPhrases() * Query fragments are added based on getLanguageToNounPhrases(), which contains NEs & CNNs * Steps: 1- runPhraseCombination: ignore quotation marks and repeated tokens combine phrases based on the heuristics 2- checkNamedEntites check if the combined phrases match a NE 3- transformTree add the combined phrases or NE to NounPhrases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned phrase combination