Introduce Semiring and refactor finite sums #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixwellen
changed the title
Merged
|
@mzeuner can you review this changes? |
mzeuner
reviewed
Sep 11, 2023
There was a problem hiding this comment.
Only had a tiny remark, which is related to an old issue #598.
Since that issue was never closed, I think we can leave it to your conscience, whether you want to keep makeCommSemiRing or whether you want define UpperNat.asCommSemiRing using copatterns.
Otherwise it should be ready to be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, we only have CommSemiring. I don't have a Semiring that is not commutative, but I want to move the definition of sum from Ring to a place where it can also be used for Nat.