[ re agda/#6368 ] Add blanket instance for TypeWithStr #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm confused, there's a CI error about a name that's not in scope but it's not even in the part that I modified. |
|
I have no clue what the CI problem is, but the PR looks good to me! |
mortberg
approved these changes
Jan 27, 2023
|
We removed the |
|
Ah I see, it seems that by rebasing I accidentally resurrected an old piece of code. I'll push a fix. |
jespercockx
force-pushed
the
issue6368-compat
branch
from
cd5ac56 to
f755e38
Compare
|
Thanks, looks good now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to merge agda/agda#6368, but this requires a (very small) change to the cubical library. I would say it is an improvement, since it means less instances have to be declared by hand.