Add headphone/environmental audio exposure data methods #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klandell
commented
Jul 14, 2021
Comment on lines
+20
to
+42
| NSUInteger limit = [RCTAppleHealthKit uintFromOptions:input key:@"limit" withDefault:HKObjectQueryNoLimit]; | ||
| BOOL ascending = [RCTAppleHealthKit boolFromOptions:input key:@"ascending" withDefault:false]; | ||
| NSDate *startDate = [RCTAppleHealthKit dateFromOptions:input key:@"startDate" withDefault:nil]; | ||
| NSDate *endDate = [RCTAppleHealthKit dateFromOptions:input key:@"endDate" withDefault:[NSDate date]]; | ||
| if(startDate == nil){ | ||
| callback(@[RCTMakeError(@"startDate is required in options", nil, nil)]); | ||
| return; | ||
| } | ||
| NSPredicate * predicate = [RCTAppleHealthKit predicateForSamplesBetweenDates:startDate endDate:endDate]; | ||
|
|
||
| [self fetchQuantitySamplesOfType:environmentalAudioExposureType | ||
| unit:unit | ||
| predicate:predicate | ||
| ascending:ascending | ||
| limit:limit | ||
| completion:^(NSArray *results, NSError *error) { | ||
| if(results){ | ||
| callback(@[[NSNull null], results]); | ||
| return; | ||
| } else { | ||
| callback(@[RCTJSErrorFromNSError(error)]); | ||
| return; | ||
| } |
There was a problem hiding this comment.
This whole chunk of code is duplicated many times in this library (including in this file). A near future enhancement could be to add a utility function to parse the inputs and fetch the samples for a given type.
There was a problem hiding this comment.
Agreed, we should get a better approach with the migration to Swift! Glad if you can help us with that.
macelai
approved these changes
Jul 19, 2021
|
Can you fix these conflicts? @klandell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for
HKQuantityTypeIdentifierHeadphoneAudioExposureandHKQuantityTypeIdentifierEnvironmentalAudioExposure.Fixes #127
Type of change
Please delete options that are not relevant.
Checklist: