replace mocha and blanket with ava and nyc #506

OmgImAlexis · 2017-08-14T14:00:37Z

This is a WIP so please keep that in mind if you decide to review before I'm 100% finished.

Since there's no easy way to check the tests are evaluating the same before and after I'd highly suggest we get at least 2 people to review this.

simison · 2017-08-14T14:03:04Z

package.json

    "date.js": "~0.3.1",
-    "debug": "^2.6.8",
+    "debug": "~3.0.0",


You can get rid of these changes by rebasing with master git rebase origin/master

This shouldn't be a problem since we squash the commits, right?

Yup no problemo!

OmgImAlexis · 2017-08-19T06:43:12Z

Can someone explain this test to me? Converted it to ava and now it fails and I think it's because ava is running faster than mocha but I'm not 100% sure.

it('does not process locked jobs', done => {
  const history = [];

  jobs.define('lock job', {
    lockLifetime: 300
  }, (job, cb) => {
    history.push(job.attrs.data.i);

    setTimeout(() => {
      cb();
    }, 150);
  });

  jobs.start();

  jobs.now('lock job', {i: 1});
  jobs.now('lock job', {i: 2});
  jobs.now('lock job', {i: 3});

  setTimeout(() => {
    expect(history).to.have.length(3);
    expect(history).to.contain(1);
    expect(history).to.contain(2);
    expect(history).to.contain(3);
    done();
  }, 500);
});

OmgImAlexis · 2017-08-19T06:43:32Z

@simison

simison · 2017-08-19T17:38:04Z

Sorry but I don't really have insight into that test :-/ Maybe @lushc can figure out what's going on in here?

In case pinging also @rschmukler

OmgImAlexis · 2017-08-24T04:35:07Z

If I can get help with a few of the integration tests then this should be done by the end of next week.

OmgImAlexis · 2017-10-18T05:34:36Z

I've got 113/123 tests passing so I've only got 10 left to finish off and I think we should be good to then review and merge.

➜  agenda git:(add-ava) ava --verbose --serial                     

  ✔ agenda › returns itself
  ✔ agenda › sets a default processEvery
  ✔ agenda › cancel › returns nothing
  ✔ agenda › cancel › should cancel a job
  ✔ agenda › cancel › should cancel multiple agenda (188ms)
  ✔ agenda › cancel › should cancel agenda only if the data matches
  ✔ agenda › create › returns a job
  ✔ agenda › create › creates a job
  ✔ agenda › default-concurrency › returns itself
  ✔ agenda › default-concurrency › sets the defaultConcurrency
  ✔ agenda › default-lock-lifetime › returns itself
  ✔ agenda › default-lock-lifetime › sets the default lock lifetime
  ✔ agenda › default-lock-lifetime › is inherited by agenda
  ✔ agenda › default-lock-limit › returns itself
  ✔ agenda › default-lock-limit › sets the defaultLockLimit
  ✔ agenda › define › returns a job
  ✔ agenda › define › stores the definition for the job
  ✔ agenda › define › sets the default concurrency for the job
  ✔ agenda › define › sets the default lockLimit for the job
  ✔ agenda › define › sets the default priority for the job
  ✔ agenda › define › takes concurrency option for the job
  ✔ agenda › every › returns a job
  ✔ agenda › every › returns an array of jobs
  ✔ agenda › every › sets the repeatEvery
  ✔ agenda › every › sets the agenda
  ✔ agenda › every › should update a job that was previously scheduled with `every`
  ✔ agenda › jobs › returns jobs
  ✔ agenda › lock-limit › returns itself
  ✔ agenda › lock-limit › sets the lockLimit
  ✔ agenda › max-concurrency › returns itself
  ✔ agenda › max-concurrency › sets the maxConcurrency
  ✔ agenda › mongo › returns itself
  ✔ agenda › mongo › sets the _db directly (779ms)
  ✔ agenda › mongo › sets the _db directly when passed as an option
  ✔ agenda › name › returns itself
  ✔ agenda › name › sets the agenda name
  ✔ agenda › now › returns a job
  ✔ agenda › now › sets the schedule
  ✔ agenda › now › runs the job immediately
  ✔ agenda › process-every › returns itself
  ✔ agenda › process-every › sets the processEvery time
  ✔ agenda › purge › returns nothing
  ✔ agenda › purge › removes all agenda without definitions
  ✔ agenda › save-job › returns a job
  ✔ agenda › save-job › persists job to the database
  ✔ agenda › schedule › returns a job
  ✔ agenda › schedule › returns an array of jobs
  ✔ agenda › schedule › sets the schedule
  ✔ agenda › sort › returns itself
  ✔ agenda › sort › sets the default sort option
  ✔ agenda › unique › returns nothing
  ✔ agenda › unique › should modify one job when unique matches
  ✔ agenda › unique › should not modify job when unique matches and insertOnly is set to true
  ✔ agenda › unique › should create two agenda when unique doesn't match
  - intergration › job-lock › runs a recurring job after a lock has expired
  - intergration › job-lock › runs a one-time job after test.skips lock expires
  - intergration › job-lock › does not process locked jobs
  - intergration › job-lock › does not on-the-fly lock more than agenda._lockLimit jobs
  - intergration › job-lock › does not on-the-fly lock more than definition.lockLimit jobs
  - intergration › job-lock › does not lock more than agenda._lockLimit jobs during processing interval
  - intergration › job-lock › does not lock more than definition.lockLimit jobs during processing interval
  ✔ job › returns itself
  ✔ job › should retry a job (554ms)
  ✔ job › compute-next-time-at › returns the job
  ✔ job › compute-next-time-at › sets to undefined if no repeat at
  ✔ job › compute-next-time-at › it understands repeatAt times
  ✔ job › compute-next-time-at › sets to undefined if no repeat interval
  ✔ job › compute-next-time-at › it understands human intervals
  ✔ job › compute-next-time-at › understands cron intervals
  ✔ job › compute-next-time-at › understands cron intervals with a timezone
  ✔ job › compute-next-time-at › understands cron intervals with a timezone when last run is the same as the interval
  ✔ job › compute-next-time-at › sets nextRunAt to undefined when repeat at time is invalid
  ✔ job › compute-next-time-at › fails the job when repeat at time is invalid
  ✔ job › compute-next-time-at › sets nextRunAt to undefined when repeat interval is invalid
  ✔ job › compute-next-time-at › fails the job when repeat interval is invalid
  ✔ job › disable › returns the job
  ✔ job › disable › sets disabled to true on the job
  ✔ job › enable › returns the job
  ✔ job › enable › sets disabled to false on the job
  ✔ job › events › emits start event
  ✔ job › events › emits start:job name event
  ✔ job › events › emits complete event
  ✔ job › events › emits complete:job name event
  ✔ job › events › emits success event
  ✔ job › events › emits success:job name event
  ✔ job › events › emits fail event
  ✔ job › events › emits fail:job name event
  ✔ job › fail › returns the job
  ✔ job › fail › takes a string
  ✔ job › fail › takes an error object
  ✔ job › fail › sets the failedAt time
  ✔ job › fail › sets the failedAt time equal to lastFinishedAt time
  ✔ job › priority › returns the job
  ✔ job › priority › sets the priority to a number
  ✔ job › priority › parses written priorities
  ✔ job › remove › returns nothing
  ✔ job › remove › removes the job
  ✔ job › repeat-at › returns the job
  ✔ job › repeat-at › sets the repeat at
  ✔ job › repeat-every › returns the job
  ✔ job › repeat-every › sets the repeat interval
  ✔ job › run › returns nothing
  ✔ job › run › updates lastRunAt
  ✔ job › run › updates nextRunAt
  ✔ job › run › fails if job is undefined
  ✔ job › run › handles errors
  ✔ job › run › handles errors with q promises (123ms)
  ✔ job › run › doesn't allow a stale job to be saved
  ✔ job › save › returns the job
  ✔ job › save › calls saveJob on the agenda
  ✔ job › save › doesnt save the job if its been removed
  ✔ job › schedule › returns the job
  ✔ job › schedule › sets the next run time
  ✔ job › schedule › sets the next run time Date object
  ✔ job › start › returns the job
  ✔ job › start › starts/stops the job queue (545ms)
  - job › start › does not run disabled jobs
  - job › start › does not throw an error trying to process undefined jobs
  - job › start › clears locks on stop
  ✔ job › touch › returns nothing
  ✔ job › touch › extends the lock lifetime
  ✔ job › unique › returns the job
  ✔ job › unique › sets the unique property

  113 tests passed [15:15:12]
  10 tests skipped

simison · 2017-08-31T11:41:20Z

package.json

-    "moment-timezone": "^0.5.0",
-    "mongodb": "^2.2.10"
+    "moment-timezone": "~0.5.0",
+    "mongodb": "~2.2.10"
  },
  "devDependencies": {


With NPM 5.2.0 this was complaining about missing packages when running npm test, so I had to:

npm i eslint-plugin-ava eslint-config-xo eslint-plugin-unicorn eslint-plugin-import --save-dev

Looks like I wrote that review comment a month ago but forgot to submit it back then. :-) Not sure if that's relevant anymore.

simison · 2017-10-18T08:00:09Z

test/agenda/cancel.js

+test('returns nothing', t => {
+  const {agenda} = t.context;
+
+  t.is(agenda.cancel('jobA'), undefined);


Good question!

I feel that attempting to cancel a job that didn't exist kinda successfully fulfils the intention here, so it would not need to error? These are always tricky ones.

I remember seeing quite a few issues around cancelling jobs.

simison · 2017-10-18T08:01:19Z

package.json

-    "moment-timezone": "^0.5.0",
-    "mongodb": "^2.2.10"
+    "moment-timezone": "~0.5.0",
+    "mongodb": "~2.2.10"


Remember to rebase with origin/master as these are updated there.

simison · 2017-10-18T08:02:27Z

test/helpers/index.js

+const clearJobs = agenda => {
+  return new Promise(resolve => {
+    debug('jobs cleared');
+    agenda._mdb.collection('agendaJobs').remove({}, resolve);


Should we also clean up indices here?

Doesn't really matter for Travis but for local testing it might matter.

We delete the whole database afterwards I was expecting that to trigger MongoDB's auto garbage collection for the indexes. Do we need to clean them ourselves?

Collection.remove() leaves them there, Collection.drop() is what you'll need.

Although I'm not sure how Mongo garbage collection works exactly, that might handle them as well.

simison · 2018-06-11T10:34:00Z

Related: #542

add ava and nyc devDeps

2d71896

OmgImAlexis requested review from simison, niftylettuce, emhagman and lushc August 14, 2017 14:00

OmgImAlexis added 3 commits August 14, 2017 23:32

export lib files via index

b734386

add helper file for ava

9a83afc

add main agenda test

4f5446a

simison reviewed Aug 14, 2017

View reviewed changes

OmgImAlexis added 21 commits August 14, 2017 23:33

remove old test files

9cc851e

add agenda.create test

a3b552c

add agenda.defaultConcurrency test

1f6b68a

add agenda.defaultLockLifetime test

a646dc7

add agenda.defaultLockLifeLimit test

486af5f

add agenda.now test

039aa6b

add agenda.define test

a62528e

add agenda.jobs test

e1d3942

add agenda.lockLimit test

cb5557b

add agenda.mongo test

96e9e09

add agenda.maxConcurrency test

2419ba4

add agenda.name test

6055f37

add agenda.processEvery test

8522495

add agenda.sort test

482e87e

remove Makefile, update travis to use yarn and remove old deps

ed3eb01

add agenda.every test

796d857

cleanup t.context assignage

a86e5e9

add agenda.purge test

1a38cbe

cleanup array test and fix typo

fa797a8

add agenda.schedule test

e531f69

add agenda.cancel test

2cb45bc

make sure tests always run afterEach

ada34f1

agenda deleted a comment from coveralls Aug 16, 2017

fabong mentioned this pull request Aug 17, 2017

Returns an error if the collection doesn't exist in cancel method #501

Open

OmgImAlexis added 4 commits August 19, 2017 15:31

add job.events test

64f9dd5

cleanup test helpers, add more test definitions

e4dffe5

skip start tests

85122d1

add retry test

3841ba7

agenda deleted a comment from coveralls Aug 19, 2017

add job lock intergration tests

1a5afb1

OmgImAlexis mentioned this pull request Aug 23, 2017

Add docs for endpoint testing with mongoose avajs/ava#1420

Merged

OmgImAlexis added 3 commits October 17, 2017 14:05

cleanup test helper

7c66327

fix more tests

5d26f64

enable working job.start tests

52d4d99

simison reviewed Oct 18, 2017

View reviewed changes

OmgImAlexis added 3 commits October 18, 2017 20:06

bump deps

2ad1f34

Merge branch 'master' into add-ava

7666d40

fix job titles

be323d8

simison requested a review from wingsbob June 11, 2018 10:34

simison added the enhancement label Jun 11, 2018

simison added this to the 3.0.0 milestone Jun 11, 2018

OmgImAlexis removed this from the 3.0.0 - old milestone Jul 20, 2018

OmgImAlexis closed this May 11, 2020

koresar deleted the add-ava branch August 6, 2021 01:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

replace mocha and blanket with ava and nyc #506

replace mocha and blanket with ava and nyc #506

OmgImAlexis commented Aug 14, 2017

simison Aug 14, 2017

OmgImAlexis Aug 14, 2017

simison Aug 14, 2017

OmgImAlexis commented Aug 19, 2017 •

edited

Loading

OmgImAlexis commented Aug 19, 2017

simison commented Aug 19, 2017

OmgImAlexis commented Aug 24, 2017

OmgImAlexis commented Oct 18, 2017

simison Aug 31, 2017

simison Oct 18, 2017

simison Oct 18, 2017

simison Oct 18, 2017

simison Oct 18, 2017 •

edited

Loading

OmgImAlexis Oct 18, 2017

simison Oct 18, 2017 •

edited

Loading

simison commented Jun 11, 2018

replace mocha and blanket with ava and nyc #506

replace mocha and blanket with ava and nyc #506

Conversation

OmgImAlexis commented Aug 14, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OmgImAlexis commented Aug 19, 2017 • edited Loading

OmgImAlexis commented Aug 19, 2017

simison commented Aug 19, 2017

OmgImAlexis commented Aug 24, 2017

OmgImAlexis commented Oct 18, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

simison Oct 18, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

simison Oct 18, 2017 • edited Loading

Choose a reason for hiding this comment

simison commented Jun 11, 2018

OmgImAlexis commented Aug 19, 2017 •

edited

Loading

simison Oct 18, 2017 •

edited

Loading

simison Oct 18, 2017 •

edited

Loading