You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To support more word numbers, instead of adding more data, we could use something like node-numbered to do this and remove some code from the project while extending it's support. Would you be accepting such contribution? What do you think?
I suppose, to use that there needs to be a little bit of refactoring on how the code works. I'm thinking we could instead use the following algorithm:
Find the units in the string and split the string using them.
Pass the remaining strings to node-numbered which will convert them to numbers.
Process it and calculate the total.
The text was updated successfully, but these errors were encountered:
Note that floats like 0.259 we will probably need to Math.round(). Actually nope! Should work just like that. Just need to check how many decimals is ok.
We've just recently moved this repo under @agenda org. Would you feel like submitting a PR + tests for this? That would be sooooo helpful.
Hello @rschmukler ,
To support more word numbers, instead of adding more data, we could use something like
node-numbered
to do this and remove some code from the project while extending it's support. Would you be accepting such contribution? What do you think?I suppose, to use that there needs to be a little bit of refactoring on how the code works. I'm thinking we could instead use the following algorithm:
node-numbered
which will convert them to numbers.The text was updated successfully, but these errors were encountered: