Refactor module to use node-numbered instead #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the long response. I have rebased the PR, so the tests now pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this removes the
languageMapsupport because it doesn't make sense and a quick search on Github didn't show anybody using it in an open source package. You can just release a semver major version.However if you don't agree with this, we could easily add it back and emulate it.
Another to note that node-numbered only supports English numbers. I was thinking to support this people could provide their own English number parser(something that does exactly what
numbered.parsedoes as an argument. We could try to extendnode-numberedbut I'm sure it'll never be good enough to support all languages with the same amount of code, so letting people having their own parser specific for their language makes the package more usable.Closes #9