Package code #6
Open
Package code #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR does the following: 1. Enforce the standard src/ directory layout 2. Add the setup.cfg and pyproject.toml with minimum metadata about installing the package 3. Add a trivial test case and tox configuration for reproducible build/installation/running of tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5
This PR does the following:
setup.cfgandpyproject.tomlwith minimum metadata about installing the packagetox.iniconfiguration file fortoxfor reproducible build/installation/running of tests..gitignorePotential extras
There are several other things I'd like to do to improve this package, but as the diff already covers 37 files, I think this would make code review much too difficult. Here are some of the ideas for a follow-up PR:
cc @devonjkohler