Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15 react tab css #22

Merged
merged 4 commits into from
Mar 16, 2021
Merged

15 react tab css #22

merged 4 commits into from
Mar 16, 2021

Conversation

agneym
Copy link
Owner

@agneym agneym commented Mar 16, 2021

Move @reach/tabs import outside

NextJS does not allow for the import inside the package and throws the error as shown in #15

We do not have any custom CSS because we use goober CSS-in-JS. If we extract a CSS file from @reach/tabs that will cause the user to import it twice if they themselves are using the library.

  • Update README with new instructions

Closes #15

@agneym agneym merged commit 3ff508a into master Mar 16, 2021
@agneym agneym deleted the 15-react-tab-css branch March 16, 2021 20:09
agneym added a commit that referenced this pull request Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global CSS cannot be imported from within node_modules
1 participant