gateway: return task containers image names in RunTaskResponse #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgotti
changed the title
sgotti
requested changes
Apr 29, 2022
There was a problem hiding this comment.
@tulliobotti64 Thanks for you PR. Some inline comments.
Can you also rename the commit to the same name of the PR (I changed it)?
tulliobotti64
force-pushed
the
16228-PodImages
branch
3 times, most recently
from
0a917c4
to
b36bcd7
Compare
tulliobotti64
force-pushed
the
16228-PodImages
branch
2 times, most recently
from
7a60e53
to
9893955
Compare
tulliobotti64
force-pushed
the
16228-PodImages
branch
from
9893955
to
039d5e7
Compare
sgotti
approved these changes
May 13, 2022
|
@tulliobotti64 LGTM. Thanks. Merging. |
|
fix #332 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we want to show all containers images used by the tasks as described in the issue 332.
Can you please review it. Thanks !