Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix imports for user model #149

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Conversation

kiikoh
Copy link
Collaborator

@kiikoh kiikoh commented Sep 21, 2022

This bug came from fef860b. This works fine for windows machines but not for Linux based systems due to the different file system behaviors.

Related issue: nodejs/node#36968

@kiikoh kiikoh added the bug Something isn't working label Sep 21, 2022
Copy link
Collaborator

@briangormanly briangormanly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

Copy link
Collaborator

@cmarcusdimarco cmarcusdimarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Great find.

@briangormanly briangormanly merged commit 75a58cb into main Sep 22, 2022
@briangormanly briangormanly deleted the require-case-insensitive-fix branch September 22, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants