Prevent timing attacks on access token verification #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any reason this PR is still outstanding? |
|
Even though it's a small change and I've tested in lua proper, ensuring that the change is working within nginx requires integration testing. That requires a build of nginx with lua support and a host that I can connect to Google. Since around the time of this PR the test environment I had been using is gone and I just haven't built a new one as this PR fell through the cracks. If anyone has a chance to test it and can report back, that would be helpful. |
|
Thanks. We're looking at this right now for a handful of internal apps. I'll see if I can have someone test this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the potential of an HMAC timing attack #5