feat(launchIt): launch a token (WIP) #7
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dckc
force-pushed
the
dc-launchpad
branch
2 times, most recently
from
39319ac
to
657f685
Compare
dckc
force-pushed
the
dc-arb-asset-naming
branch
from
c69d6ff
to
37ebda2
Compare
dckc
force-pushed
the
dc-launchpad
branch
3 times, most recently
from
28f316e
to
67332ee
Compare
separate contract for each launch, using contractStarter13 tests are passing as of 2029597. The launcher Larry, story, so far, is: |
| * @param {string} kw | ||
| */ | ||
| const makeZcfIssuerKit = async (zcf, kw) => { | ||
| const mint = await zcf.makeZCFMint(kw); |
There was a problem hiding this comment.
I wonder if it's better to throw, than to prepend with KW. Is ^[A-Z]/ something that could/should be supported by @endo/patterns?
There was a problem hiding this comment.
yeah; that's clearly a KLUDGE
endo/patterns avoids regex stuff.
The core issue is: makeZCFMint conflates issuerName with keyword. I want the brand to print as BRD, but keywords are more naturally for a role played by a brand in the contract; in this case, Minted. IOU an agoric-sdk issue on this.
working in 1 case: Larry launches BRD; market discovers priceLarry minted 1_000_000 BRD. A dozen fans bought shares and the market discovered a price of 0.000379 MNY/BRD. 2024-01-15 15:35 9d88719 test-launchIt: basic scenario complete yarn test test/test-launchIt.js |
dtribble
reviewed
Jan 15, 2024
| { want: { Shares: ShapeAmt.Share } }, | ||
| ), | ||
| Withdraw: M.splitRecord({ | ||
| want: { Deposit: ShapeAmt.Deposit }, |
There was a problem hiding this comment.
This has different bracing than the previous lines. That seems more like a bug than a difference.
dckc
commented
Jan 15, 2024
| }, | ||
| }; | ||
| // export these from a client interface module? | ||
| const Shape = harden({ |
There was a problem hiding this comment.
there's a subtle difference between M.splitRecord({ give: X, want: Y}) and M.splitRecord({ give: X }, { want: Y })
merits a comment
ack: @dtribble
| */ | ||
| export const start = async (zcf, _privateArgs, _baggage) => { | ||
| const { name, supplyQty, displayInfo = {}, brands } = zcf.getTerms(); | ||
| mustMatch(brands, M.splitRecord({ Deposit: BrandShape })); |
There was a problem hiding this comment.
Why M.splitRecord(...) instead of harden({ Deposit: BrandShape })? Are we expecting brands to be keyed with anything else?
There was a problem hiding this comment.
At the time, I only needed this brand to exist for the code I was writing to be correct.
Stepping back and looking at the whole thing now, no, I don't think there are any others.
dtribble
reviewed
Jan 15, 2024
start launchIt with contractStarter on a local chain
deploy contract starter: yarn docker:make deploy-contractyarn docker:make install-launchItstart launchIt with contractStarter: offer-tool.js bundles/bundle-launchIt.json |
dckc
force-pushed
the
dc-starter
branch
4 times, most recently
from
c79876c
to
2e8dd66
Compare
dckc
force-pushed
the
dc-launchpad
branch
3 times, most recently
from
9d5a04c
to
f08702b
Compare
- use zoe exit for deadline - test-launchIt: start with contractStarter - larry returns instance so others can subscribe / deposit - Larry's wallet needs to know about MNY (recall upcoming HACK to add stuff to agoricNames) - NEEDSTEST: withdraw - NEEDSTEST: unhappy paths, esp timing - test: prune albert dead code tests: ✔ boot, walletFactory, contractStarter ✔ start launchIt instance to launch token
- update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
goal:
fixes #15
DRAFT until: