Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snapshots): raise the per snapshot item limit #304

Merged
merged 3 commits into from
Sep 13, 2023

Conversation

mhofman
Copy link

@mhofman mhofman commented Sep 12, 2023

Description

Closes: Agoric/agoric-sdk#8325

Increases the snapshot per item size limit when restoring from state-sync, and add a test verifying a payload just below the size can be read.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Copy link

@JimLarson JimLarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one suggested comment.

snapshots/manager.go Show resolved Hide resolved
@mhofman mhofman merged commit fe7b578 into Agoric Sep 13, 2023
30 of 31 checks passed
@mhofman mhofman deleted the mhofman/8325-increase-snapshot-size-limit branch September 13, 2023 17:51
toliaqat pushed a commit that referenced this pull request Oct 12, 2023
Increases the snapshot per item size limit when restoring from state-sync
JeancarloBarrios pushed a commit that referenced this pull request Sep 28, 2024
Increases the snapshot per item size limit when restoring from state-sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

state-sync cannot restore payloads larger than 64MB
2 participants