Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to make type-module tolerant #1

Merged
merged 1 commit into from
May 23, 2021

Conversation

michaelfig
Copy link
Collaborator

Implements standard-things#877.

Copy link

@kriskowal kriskowal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to have a test that illustrates the intended consequence. Are we going to publish an @agoric/esm fork? (I would like to reserve @endo/esm for the possibility of an Endo based node -r @endo/esm feature.

@shivjm
Copy link

shivjm commented May 23, 2021

Not sure what exactly is going on, but thank you for this. After pulling out my hair for hours over standard-things#868, installing this branch with npm i -D agoric-labs/esm#mfig-type-module-tolerant was the only thing that got my code working.

@michaelfig michaelfig merged commit 8db4b72 into Agoric May 23, 2021
@michaelfig
Copy link
Collaborator Author

Not sure what exactly is going on, but thank you for this. After pulling out my hair for hours over standard-things#868, installing this branch with npm i -D agoric-labs/esm#mfig-type-module-tolerant was the only thing that got my code working.

Thanks @shivjm! If you need to point anybody else at this branch, I've updated the README, and posted a reference to it at standard-things#897.

@michaelfig
Copy link
Collaborator Author

Note to future self: don't delete this branch in case anybody still depends on it!

@shivjm
Copy link

shivjm commented May 24, 2021

Many thanks! Will you be carrying on development in the Agoric branch or in Agoric-built? For my part, at least, I can simply update my code to point to wherever you think makes sense.

@michaelfig
Copy link
Collaborator Author

Many thanks! Will you be carrying on development in the Agoric branch or in Agoric-built? For my part, at least, I can simply update my code to point to wherever you think makes sense.

Agoric is the non-minified code. Agoric-built is just the minified version. We will keep Agoric-built up-to-date if we make any changes to Agoric, so it really is up to you which one you want to point to.

@shivjm
Copy link

shivjm commented May 25, 2021

Gotcha. I’ll update the branch I’m using. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants