-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On next, dispatches requestType rather than failureType for fetch errors #99
Comments
@Andrew-Hagedorn-ZocDoc Things are fluid right now. I hadn't touched this library in a long time and I am in the process of addressing some of the issues. In the meantime, the |
I'm also confused with it, how do you handle errors if it dispatches requestType? |
@agraboso Sorry for nagging, but I'm trying to understand logic at this point. Why does it dispatches "request" type instead of "failure"? There is no real http request performed in case of invalid RSAA and definitely should be failure in case of error for me.. |
Previously: RSAA -> Request FSA -> Request Error FSA Now: RSAA -> Request FSA -> Failure FSA Closes agraboso#26 agraboso#44 agraboso#99
Update: I'm hoping to push out #175 in a 3.0 release soon |
#175 was merged into the I hope to have a beta published to npm in the next few days. Closing this issue out now but feel free to re-open or continue commenting here. |
On the next branch, when there is failed request on fetch it dispatches the
requestType
rather than the expectedfailureType
:https://github.com/agraboso/redux-api-middleware/blob/next/src/middleware.js#L107
Is this the expected behavior?
The text was updated successfully, but these errors were encountered: