Prevent entering an existing option in the "Other" dialog

Closes #75
agrc · May 11, 2018 · 0ab2215 · 0ab2215
1 parent 3069659
commit 0ab2215
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/_src/app/OtherOptionHandler.js b/_src/app/OtherOptionHandler.js
@@ -84,9 +84,11 @@ define([
             // event: Event Object
             console.log('app/OtherOptionHandler:onTxtChange', arguments);
 
-            this.submitBtn.disabled = !(this.codeTxt.value.length > 0);
+            const value = this.codeTxt.value.toUpperCase();
+            this.submitBtn.disabled = !value || !(value.length > 0) ||
+                this.existingOptions.map(v => v.toUpperCase()).includes(value);
 
-            if (event.key === 'Enter') {
+            if (!this.submitBtn.disabled && event.key === 'Enter') {
                 this.onSubmit();
             }
         },

diff --git a/_src/app/tests/spec/SpecOtherOptionHandler.js b/_src/app/tests/spec/SpecOtherOptionHandler.js
@@ -18,7 +18,8 @@ require([
             widget = null;
         };
         var select;
-        var options = ['code1', 'code2', 'code3'];
+        const code1 = 'code1';
+        var options = [code1, 'code2', 'code3'];
 
         beforeEach(function () {
             select = domConstruct.create('select', {}, win.body());
@@ -57,5 +58,15 @@ require([
                 testWidget.onSubmit();
             });
         });
+
+        describe('onTxtChange', function () {
+            it('does not allow for an existing value to be submitted', function () {
+                testWidget.codeTxt.value = code1.toUpperCase();
+
+                testWidget.onTxtChange({});
+
+                expect(testWidget.submitBtn.disabled).toBe(true);
+            });
+        });
     });
 });