fix: gracefully handle 404s from web api

Closes #98
agrc · Dec 17, 2022 · 464e938 · 464e938
1 parent 741bee7
commit 464e938
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -13,12 +13,14 @@
     "ADDSYSTEM",
     "AGRC",
     "atch",
+    "backoff",
     "Buildx",
     "CAROOT",
     "choco",
     "cloudrun",
     "codecov",
     "dotenv",
+    "forcelist",
     "FULLADD",
     "geocoder",
     "geosearch",

diff --git a/src/masquerade/providers/web_api.py b/src/masquerade/providers/web_api.py
@@ -105,6 +105,9 @@ def make_request(address, zone, out_spatial_reference, max_locations):
 
     response = session.get(url, params=parameters, headers=headers)
 
+    if response.status_code == 404 and 'no address candidates found' in response.text.lower():
+        return []
+
     if response.ok:
         try:
             result = response.json()['result']

diff --git a/tests/test_web_api.py b/tests/test_web_api.py
@@ -251,9 +251,16 @@ def test_get_address_candidates_raises(requests_mock):
 
 
 def test_get_address_candidates_bad_address(requests_mock):
-    requests_mock.get(re.compile(f'{WEB_API_URL}.*'), json={}, status_code=500)
+    requests_mock.get(
+        re.compile(f'{WEB_API_URL}.*'),
+        json={
+            "status": 404,
+            "message": "No address candidates found with a score of 70 or better."
+        },
+        status_code=404
+    )
 
-    candidates = get_candidates_from_single_line('bad address', 3857, 5)
+    candidates = get_candidates_from_single_line('123 bad address, city name', 3857, 5)
 
     assert len(candidates) == 0