fix: handle string values for max suggestions param (#133)

agrc · Jun 12, 2023 · 9d6a739 · 9d6a739
1 parent cd56484
commit 9d6a739
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/masquerade/main.py b/src/masquerade/main.py
@@ -176,6 +176,8 @@ def suggest():
 
     search_text = request.args.get('text')
     max_results = request.args.get('maxSuggestions') or DEFAULT_MAX_SUGGESTIONS
+    if isinstance(max_results, str):
+        max_results = DEFAULT_MAX_SUGGESTIONS
 
     return {'suggestions': open_sgid.get_suggestions(cleanse_text(search_text), max_results)}
 

diff --git a/tests/test_masquerade.py b/tests/test_masquerade.py
@@ -73,3 +73,13 @@ def test_head_requests(test_client):
 
     assert response.status_code == 200
     assert response.headers['Cache-Control']
+
+
+def test_can_handle_bad_values(test_client):
+    response = test_client.get(f'{GEOCODE_SERVER_ROUTE}/suggest?text=123&maxSuggestions=undefined')
+
+    assert response.status_code == 200
+
+    response_json = json.loads(response.data)
+
+    assert len(response_json['suggestions']) > 0