[#388] Add conf ls to get the configuration file locations
#389
+363
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introducing the command `conf ls` to `pgagroal-cli` that prints out where the configuration files are located. A new management key, action and three new management methods have been added to implement the logic. The idea is that, once the action is required, the management prints on the socket every single `struct configuration*` path variables, and then the management read method reads back in the same order to the same list of values to be printed on the output screen. In order to achieve this, two new static functions have been added to the managemenet in order to write and read from the socket a single path. A path is written with a size and the following path, assuming it will never be larger than MAX_PATH or an error will be thrown. In the case a path is NULL or empty, an empty string will be written on the socket and so the final result is that the entry will be printed as empty in the command output. Documentation updated. Shell completions updated. Fixes also a few log_trace in the cli application. Close agroal#388
|
Merged. Thanks for your contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing the command
conf lstopgagroal-clithat prints out where the configuration files are located.A new management key, action and three new management methods have been added to implement the logic.
The idea is that, once the action is required, the management prints on the socket every single
struct configuration*path variables, and then the management read method reads back in the same order to the same list of values to be printed on the output screen.In order to achieve this, two new static functions have been added to the managemenet in order to write and read from the socket a single path. A path is written with a size and the following path, assuming it will never be larger than MAX_PATH or an error will be thrown. In the case a path is NULL or empty, an empty string will be written on the socket and so the final result is that the entry will be printed as empty in the command output.
Documentation updated.
Shell completions updated.
Fixes also a few log_trace in the cli application.
Close #388