Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed TypeError when TLS handshake fails with truststore SSLContext #801

Merged
merged 6 commits into from
Oct 13, 2024

Conversation

agronholm
Copy link
Owner

@agronholm agronholm commented Oct 2, 2024

Changes

Fixed TypeError when TLS handshake fails with truststore SSLContext.
We shouldn't assume that SSLError.strerror is always a string.

Fixes #795.

Checklist

If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):

  • You've added tests (in tests/) added which would fail without your patch
  • You've updated the documentation (in docs/, in case of behavior changes or new
    features)
  • You've added a new changelog entry (in docs/versionhistory.rst).

If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.

Updating the changelog

If there are no entries after the last release, use **UNRELEASED** as the version.
If, say, your patch fixes issue #123, the entry should look like this:

* Fix big bad boo-boo in task groups (#123 <https://github.com/agronholm/anyio/issues/123>_; PR by @yourgithubaccount)

If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.

@agronholm agronholm marked this pull request as ready for review October 12, 2024 13:29
@agronholm agronholm merged commit ede2029 into master Oct 13, 2024
16 checks passed
@agronholm agronholm deleted the fix-795 branch October 13, 2024 11:11
agronholm added a commit that referenced this pull request Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using a truststore SSLContext, certificate verification fails.
2 participants