Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid refcycles in tracebacks from happy eyeballs exceptions #809

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

graingert
Copy link
Collaborator

@graingert graingert commented Oct 13, 2024

Changes

Checklist

If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):

  • You've added tests (in tests/) added which would fail without your patch
  • You've updated the documentation (in docs/, in case of behavior changes or new
    features)
  • You've added a new changelog entry (in docs/versionhistory.rst).

If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.

Updating the changelog

If there are no entries after the last release, use **UNRELEASED** as the version.
If, say, your patch fixes issue #123, the entry should look like this:

* Fix big bad boo-boo in task groups (#123 <https://github.com/agronholm/anyio/issues/123>_; PR by @yourgithubaccount)

If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.

@graingert graingert force-pushed the happy-eyeballs-cyclic-garbage branch from 41264d3 to c217d95 Compare October 13, 2024 11:22
exc = e.__cause__

assert isinstance(exc, OSError)
assert gc.get_referrers(exc) == no_other_refs()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is failing on trio for <3.13 I think it's an issue related to trio KI handling and fixed in https://peps.python.org/pep-0667/

@graingert
Copy link
Collaborator Author

This is failing on Python3.9 because anyio is using asyncio.get_running_loop().create_connection() which in 3.9 didn't delete its reference to exceptions I think it should use sock.bind() + asyncio.get_running_loop().sock_connect instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant