Makes __{a}exit__ method args nullable.

This makes the methods compatible with typeshed's ABCs: https://github.com/python/typeshed/blob/5e9589dd75f8a5f39a38a2ed45f098ff62babc7f/stdlib/contextlib.pyi#L40-L54 Closes #874
agronholm · Feb 29, 2024 · 8f1b6c5 · 8f1b6c5
1 parent 5fac5ba
commit 8f1b6c5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/apscheduler/_schedulers/async_.py b/src/apscheduler/_schedulers/async_.py
@@ -169,9 +169,9 @@ async def __aenter__(self) -> Self:
 
     async def __aexit__(
         self,
-        exc_type: type[BaseException],
-        exc_val: BaseException,
-        exc_tb: TracebackType,
+        exc_type: type[BaseException] | None,
+        exc_val: BaseException | None,
+        exc_tb: TracebackType | None,
     ) -> None:
         await self.stop()
         await self._exit_stack.__aexit__(exc_type, exc_val, exc_tb)

diff --git a/src/apscheduler/_schedulers/sync.py b/src/apscheduler/_schedulers/sync.py
@@ -124,9 +124,9 @@ def __enter__(self: Self) -> Self:
 
     def __exit__(
         self,
-        exc_type: type[BaseException],
-        exc_val: BaseException,
-        exc_tb: TracebackType,
+        exc_type: type[BaseException] | None,
+        exc_val: BaseException | None,
+        exc_tb: TracebackType | None,
     ) -> None:
         if self._exit_stack:
             self._exit_stack.__exit__(exc_type, exc_val, exc_tb)