-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wakeup worker when there are resources freed up #882
Conversation
I would appreciate if you can help me understand why some tests are failing. @agronholm |
Would it be possible for you to add a regression test for this? |
Oh, and also add a changelog entry (credit yourself too). |
I will look into writing tests over the weekend. Thanks for your fast response! |
Any progress on those tests? |
Sorry man, I am so busy with moving that haven't had any chance to look at it. |
One issue I have with this PR is that it needlessly wakes up the job processor whenever a job is released, not just when the processor was previously at capacity. Could you fix that? |
But if you're still busy with IRL stuff, let me know and I'll look into fixing it and writing tests. |
I've added the test and changelog entry on your behalf. Thank you for the contribution! |
Related to the bug reported on Issue#881.