Use get_protocol_members in protocol checking #490

antonagestam · 2024-09-21T10:52:29Z

Changes

This changes check_protocol() to make use of get_protocol_members from typing-extensions. This allows removing an existing hard-coded exclusion list for attributes existing on Protocol, but also handles the cases __orig_bases__ and __weakref__ that was breaking when checking intersecting protocols (a subclass of two or more protocols).

This has the effect of turning some false positives into true negatives, but it also leaves some false negatives. To make that clear, xfail test cases are added for the resulting false negatives.

Checklist

If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):

You've added tests (in tests/) added which would fail without your patch
You've updated the documentation (in docs/, in case of behavior changes or new
features)
You've added a new changelog entry (in docs/versionhistory.rst).

If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.

Updating the changelog

If there are no entries after the last release, use **UNRELEASED** as the version.
If, say, your patch fixes issue #999, the entry should look like this:

* Fix big bad boo-boo in the pytest plugin (#999 <https://github.com/agronholm/typeguard/issues/999>_; PR by @yourgithubaccount)

If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.

coveralls · 2024-09-21T10:54:38Z

coverage: 94.217% (-0.1%) from 94.341%
when pulling 42cdc09 on antonagestam:fix-type-check-intersection-protocols
into c72b675 on agronholm:master.

agronholm · 2024-09-21T11:06:36Z

Shouldn't the proper fix involve typing_extensions.get_protocol_members()?

antonagestam · 2024-09-21T11:46:51Z

Shouldn't the proper fix involve typing_extensions.get_protocol_members()?

Ah I see, thanks. I was not aware of that utility. Would something like this change make sense if it used get_protocol_members? I mean specifically about the xfails introduced. Or would you rather also see those addressed all in one go?

agronholm · 2024-09-21T11:48:29Z

Would it require a lot more effort to fix all of it?

antonagestam · 2024-09-21T13:54:29Z

@agronholm I think it might be a larger effort, and I'm now not sure it's the correct thing to do either, perhaps protocol checking should really be "flat". Making those test cases pass seems more related to supporting type variables.

I think this PR is reasonably scoped now.

agronholm · 2024-09-21T13:56:12Z

I'm currently running my own, uncommitted protocol tests against this branch. I'm hoping it will fix other protocol issues too.

agronholm

Needs some code style updates.

tests/test_checkers.py

agronholm · 2024-09-21T15:30:31Z

Once you've addressed my comments, I'll merge this and add further fixes to Protocol support.

This changes `check_protocol()` to make use of `get_protocol_members` from typing-extensions. This allows removing an existing hard-coded exclusion list for attributes existing on Protocol, but also handles the cases `__orig_bases__` and `__weakref__` that was breaking when checking intersecting protocols (a subclass of two or more protocols). This has the effect of turning some false positives into true negatives, but it also leaves some false negatives. To make that clear, xfail test cases are added for the resulting false negatives.

antonagestam · 2024-09-21T18:13:35Z

@agronholm Thanks for reviewing, the comments are now addressed 👍

agronholm · 2024-09-21T18:13:46Z

Thanks!

for agronholm/typeguard#490, for Python 3.12 tests

ryan-williams · 2024-10-21T18:35:03Z

@agronholm sorry to bug, just wondering if there's any plans for a release that will include this change?

for agronholm/typeguard#490, for Python 3.12 tests

agronholm · 2024-10-21T18:47:07Z

I still need to fix #465 as it's a regression from the previous release.

* [python] Python 3.12 support * `python-ci-packaging`: consistent dep order * use Typeguard@HEAD for agronholm/typeguard#490, for Python 3.12 tests * rm `soma@kerl/python-3.12` CI pin --------- Co-authored-by: Ryan Williams <ryan.williams@tiledb.com>

agronholm · 2024-10-27T10:01:56Z

If you want to speed things up, you could help review the new PR.

….13.3,<4.5.0 in /packages/@jsii/python-runtime (#4683) Updates the requirements on [typeguard](https://github.com/agronholm/typeguard) to permit the latest version. <details> <summary>Release notes</summary> Sourced from <a href="https://github.com/agronholm/typeguard/releases">typeguard's releases</a>. <blockquote> <h2>4.4.0</h2> <ul> <li>Added proper checking for method signatures in protocol checks (<a href="https://redirect.github.com/agronholm/typeguard/pull/465">#465</a>)</li> <li>Fixed basic support for intersection protocols (<a href="https://redirect.github.com/agronholm/typeguard/pull/490">#490</a>; PR by <a href="https://github.com/antonagestam"><code>@antonagestam</code></a>)</li> <li>Fixed protocol checks running against the class of an instance and not the instance itself (this produced wrong results for non-method member checks)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> Sourced from <a href="https://github.com/agronholm/typeguard/blob/master/docs/versionhistory.rst">typeguard's changelog</a>. <blockquote> <h1>Version history</h1> This library adheres to <code>Semantic Versioning 2.0 <https://semver.org/#semantic-versioning-200></code>_. 4.4.0 (2024-10-27) <ul> <li>Added proper checking for method signatures in protocol checks (<code>[#465](agronholm/typeguard#465) <https://github.com/agronholm/typeguard/pull/465></code>_)</li> <li>Fixed basic support for intersection protocols (<code>[#490](agronholm/typeguard#490) <https://github.com/agronholm/typeguard/pull/490></code>_; PR by <a href="https://github.com/antonagestam"><code>@antonagestam</code></a>)</li> <li>Fixed protocol checks running against the class of an instance and not the instance itself (this produced wrong results for non-method member checks)</li> </ul> 4.3.0 (2024-05-27) <ul> <li>Added support for checking against static protocols</li> <li>Fixed some compatibility problems when running on Python 3.13 (<code>[#460](agronholm/typeguard#460) <https://github.com/agronholm/typeguard/issues/460></code>_; PR by <a href="https://github.com/JelleZijlstra"><code>@JelleZijlstra</code></a>)</li> <li>Fixed test suite incompatibility with pytest 8.2 (<code>[#461](agronholm/typeguard#461) <https://github.com/agronholm/typeguard/issues/461></code>_)</li> <li>Fixed pytest plugin crashing on pytest version older than v7.0.0 (even if it's just present) (<code>[#343](agronholm/typeguard#343) <https://github.com/agronholm/typeguard/issues/343></code>_)</li> </ul> 4.2.1 (2023-03-24) <ul> <li>Fixed missing <code>typing_extensions</code> dependency for Python 3.12 (<code>[#444](agronholm/typeguard#444) <https://github.com/agronholm/typeguard/issues/444></code>_)</li> <li>Fixed deprecation warning in the test suite on Python 3.13 (<code>[#444](agronholm/typeguard#444) <https://github.com/agronholm/typeguard/issues/444></code>_)</li> </ul> 4.2.0 (2023-03-23) <ul> <li>Added support for specifying options for the pytest plugin via pytest config files (<code>[#440](agronholm/typeguard#440) <https://github.com/agronholm/typeguard/issues/440></code>_)</li> <li>Avoid creating reference cycles when type checking unions (PR by Shantanu)</li> <li>Fixed <code>Optional[...]</code> being removed from the AST if it was located within a subscript (<code>[#442](agronholm/typeguard#442) <https://github.com/agronholm/typeguard/issues/442></code>_)</li> <li>Fixed <code>TypedDict</code> from <code>typing_extensions</code> not being recognized as one (<code>[#443](agronholm/typeguard#443) <https://github.com/agronholm/typeguard/issues/443></code>_)</li> <li>Fixed <code>typing</code> types (<code>dict[str, int]</code>, <code>List[str]</code>, etc.) not passing checks against <code>type</code> or <code>Type</code> (<code>[#432](agronholm/typeguard#432) <https://github.com/agronholm/typeguard/issues/432></code>_, PR by Yongxin Wang)</li> <li>Fixed detection of optional fields (<code>NotRequired[...]</code>) in <code>TypedDict</code> when using forward references (<code>[#424](agronholm/typeguard#424) <https://github.com/agronholm/typeguard/issues/424></code>_)</li> <li>Fixed mapping checks against Django's <code>MultiValueDict</code> (<code>[#419](agronholm/typeguard#419) <https://github.com/agronholm/typeguard/issues/419></code>_)</li> </ul> 4.1.5 (2023-09-11) </blockquote> ... (truncated) </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/agronholm/typeguard/commit/efa1166c85be9a1280090fea9c287b5e4e9f3830"><code>efa1166</code></a> Added release date</li> <li><a href="https://github.com/agronholm/typeguard/commit/b72794dffe403254881ac0c327155357c43ccebf"><code>b72794d</code></a> Added proper Protocol method signature checking (<a href="https://redirect.github.com/agronholm/typeguard/issues/496">#496</a>)</li> <li><a href="https://github.com/agronholm/typeguard/commit/afad2c7b6be830900776922bb39f9346c2e77f6f"><code>afad2c7</code></a> Sorted the Ruff rules alphabetically</li> <li><a href="https://github.com/agronholm/typeguard/commit/d812f2eba9f5e898544eb4b3e597f8c38b0952e8"><code>d812f2e</code></a> Migrated to native tox TOML configuration</li> <li><a href="https://github.com/agronholm/typeguard/commit/0c50de6144d99eedb402a8e85eb8187098f8c26f"><code>0c50de6</code></a> Declared Python 3.13 support</li> <li><a href="https://github.com/agronholm/typeguard/commit/cf25d56dc0dbf6bb2f51ea29da8436b368ed4857"><code>cf25d56</code></a> Fixed annotation for typeguard_ignore() to match one for typing.no_type_check...</li> <li><a href="https://github.com/agronholm/typeguard/commit/604b08d5ba7c1b6e3d2f2ddd50dcf020f7e2794a"><code>604b08d</code></a> Use get_protocol_members in protocol checking (<a href="https://redirect.github.com/agronholm/typeguard/issues/490">#490</a>)</li> <li><a href="https://github.com/agronholm/typeguard/commit/c72b6752b7069d695898ea29abb2a31983c1bf80"><code>c72b675</code></a> [pre-commit.ci] pre-commit autoupdate (<a href="https://redirect.github.com/agronholm/typeguard/issues/471">#471</a>)</li> <li><a href="https://github.com/agronholm/typeguard/commit/ac7ac342a61db284872430c95d5e6ed7a035b7c0"><code>ac7ac34</code></a> Fixed the documentation build</li> <li><a href="https://github.com/agronholm/typeguard/commit/2c035b306996f742705da66ef64a052e715a94e2"><code>2c035b3</code></a> Assume that typing_extensions is always installed (<a href="https://redirect.github.com/agronholm/typeguard/issues/487">#487</a>)</li> <li>Additional commits viewable in <a href="https://github.com/agronholm/typeguard/compare/2.13.3...4.4.0">compare view</a></li> </ul> </details> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

Bumps [typeguard](https://github.com/agronholm/typeguard) from 4.3.0 to 4.4.0. <details> <summary>Release notes</summary> Sourced from <a href="https://github.com/agronholm/typeguard/releases">typeguard's releases</a>. <blockquote> <h2>4.4.0</h2> <ul> <li>Added proper checking for method signatures in protocol checks (<a href="https://redirect.github.com/agronholm/typeguard/pull/465">#465</a>)</li> <li>Fixed basic support for intersection protocols (<a href="https://redirect.github.com/agronholm/typeguard/pull/490">#490</a>; PR by <a href="https://github.com/antonagestam"><code>@antonagestam</code></a>)</li> <li>Fixed protocol checks running against the class of an instance and not the instance itself (this produced wrong results for non-method member checks)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> Sourced from <a href="https://github.com/agronholm/typeguard/blob/master/docs/versionhistory.rst">typeguard's changelog</a>. <blockquote> <h1>Version history</h1> This library adheres to <code>Semantic Versioning 2.0 <https://semver.org/#semantic-versioning-200></code>_. 4.4.0 (2024-10-27) <ul> <li>Added proper checking for method signatures in protocol checks (<code>[#465](agronholm/typeguard#465) <https://github.com/agronholm/typeguard/pull/465></code>_)</li> <li>Fixed basic support for intersection protocols (<code>[#490](agronholm/typeguard#490) <https://github.com/agronholm/typeguard/pull/490></code>_; PR by <a href="https://github.com/antonagestam"><code>@antonagestam</code></a>)</li> <li>Fixed protocol checks running against the class of an instance and not the instance itself (this produced wrong results for non-method member checks)</li> </ul> 4.3.0 (2024-05-27) <ul> <li>Added support for checking against static protocols</li> <li>Fixed some compatibility problems when running on Python 3.13 (<code>[#460](agronholm/typeguard#460) <https://github.com/agronholm/typeguard/issues/460></code>_; PR by <a href="https://github.com/JelleZijlstra"><code>@JelleZijlstra</code></a>)</li> <li>Fixed test suite incompatibility with pytest 8.2 (<code>[#461](agronholm/typeguard#461) <https://github.com/agronholm/typeguard/issues/461></code>_)</li> <li>Fixed pytest plugin crashing on pytest version older than v7.0.0 (even if it's just present) (<code>[#343](agronholm/typeguard#343) <https://github.com/agronholm/typeguard/issues/343></code>_)</li> </ul> 4.2.1 (2023-03-24) <ul> <li>Fixed missing <code>typing_extensions</code> dependency for Python 3.12 (<code>[#444](agronholm/typeguard#444) <https://github.com/agronholm/typeguard/issues/444></code>_)</li> <li>Fixed deprecation warning in the test suite on Python 3.13 (<code>[#444](agronholm/typeguard#444) <https://github.com/agronholm/typeguard/issues/444></code>_)</li> </ul> 4.2.0 (2023-03-23) <ul> <li>Added support for specifying options for the pytest plugin via pytest config files (<code>[#440](agronholm/typeguard#440) <https://github.com/agronholm/typeguard/issues/440></code>_)</li> <li>Avoid creating reference cycles when type checking unions (PR by Shantanu)</li> <li>Fixed <code>Optional[...]</code> being removed from the AST if it was located within a subscript (<code>[#442](agronholm/typeguard#442) <https://github.com/agronholm/typeguard/issues/442></code>_)</li> <li>Fixed <code>TypedDict</code> from <code>typing_extensions</code> not being recognized as one (<code>[#443](agronholm/typeguard#443) <https://github.com/agronholm/typeguard/issues/443></code>_)</li> <li>Fixed <code>typing</code> types (<code>dict[str, int]</code>, <code>List[str]</code>, etc.) not passing checks against <code>type</code> or <code>Type</code> (<code>[#432](agronholm/typeguard#432) <https://github.com/agronholm/typeguard/issues/432></code>_, PR by Yongxin Wang)</li> <li>Fixed detection of optional fields (<code>NotRequired[...]</code>) in <code>TypedDict</code> when using forward references (<code>[#424](agronholm/typeguard#424) <https://github.com/agronholm/typeguard/issues/424></code>_)</li> <li>Fixed mapping checks against Django's <code>MultiValueDict</code> (<code>[#419](agronholm/typeguard#419) <https://github.com/agronholm/typeguard/issues/419></code>_)</li> </ul> 4.1.5 (2023-09-11)  </blockquote> ... (truncated) </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/agronholm/typeguard/commit/efa1166c85be9a1280090fea9c287b5e4e9f3830"><code>efa1166</code></a> Added release date</li> <li><a href="https://github.com/agronholm/typeguard/commit/b72794dffe403254881ac0c327155357c43ccebf"><code>b72794d</code></a> Added proper Protocol method signature checking (<a href="https://redirect.github.com/agronholm/typeguard/issues/496">#496</a>)</li> <li><a href="https://github.com/agronholm/typeguard/commit/afad2c7b6be830900776922bb39f9346c2e77f6f"><code>afad2c7</code></a> Sorted the Ruff rules alphabetically</li> <li><a href="https://github.com/agronholm/typeguard/commit/d812f2eba9f5e898544eb4b3e597f8c38b0952e8"><code>d812f2e</code></a> Migrated to native tox TOML configuration</li> <li><a href="https://github.com/agronholm/typeguard/commit/0c50de6144d99eedb402a8e85eb8187098f8c26f"><code>0c50de6</code></a> Declared Python 3.13 support</li> <li><a href="https://github.com/agronholm/typeguard/commit/cf25d56dc0dbf6bb2f51ea29da8436b368ed4857"><code>cf25d56</code></a> Fixed annotation for typeguard_ignore() to match one for typing.no_type_check...</li> <li><a href="https://github.com/agronholm/typeguard/commit/604b08d5ba7c1b6e3d2f2ddd50dcf020f7e2794a"><code>604b08d</code></a> Use get_protocol_members in protocol checking (<a href="https://redirect.github.com/agronholm/typeguard/issues/490">#490</a>)</li> <li><a href="https://github.com/agronholm/typeguard/commit/c72b6752b7069d695898ea29abb2a31983c1bf80"><code>c72b675</code></a> [pre-commit.ci] pre-commit autoupdate (<a href="https://redirect.github.com/agronholm/typeguard/issues/471">#471</a>)</li> <li><a href="https://github.com/agronholm/typeguard/commit/ac7ac342a61db284872430c95d5e6ed7a035b7c0"><code>ac7ac34</code></a> Fixed the documentation build</li> <li><a href="https://github.com/agronholm/typeguard/commit/2c035b306996f742705da66ef64a052e715a94e2"><code>2c035b3</code></a> Assume that typing_extensions is always installed (<a href="https://redirect.github.com/agronholm/typeguard/issues/487">#487</a>)</li> <li>Additional commits viewable in <a href="https://github.com/agronholm/typeguard/compare/4.3.0...4.4.0">compare view</a></li> </ul> </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=typeguard&package-manager=pip&previous-version=4.3.0&new-version=4.4.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

Bumps [typeguard](https://github.com/agronholm/typeguard) from 4.4.0 to 4.4.1. <details> <summary>Release notes</summary> Sourced from <a href="https://github.com/agronholm/typeguard/releases">typeguard's releases</a>. <blockquote> <h2>4.4.1</h2> <ul> <li>Dropped Python 3.8 support</li> <li>Changed the signature of <code>typeguard_ignore()</code> to be compatible with <code>typing.no_type_check()</code> (PR by <a href="https://github.com/jolaf"><code>@jolaf</code></a>)</li> <li>Avoid creating reference cycles when type checking uniontypes and classes</li> <li>Fixed checking of variable assignments involving tuple unpacking (<a href="https://redirect.github.com/agronholm/typeguard/issues/486">#486</a>)</li> <li>Fixed <code>TypeError</code> when checking a class against <code>type[Self]</code> (<a href="https://redirect.github.com/agronholm/typeguard/issues/481">#481</a>)</li> <li>Fixed checking of protocols on the class level (against <code>type[SomeProtocol]</code>) (<a href="https://redirect.github.com/agronholm/typeguard/issues/498">#498</a>)</li> <li>Fixed <code>Self</code> checks in instance/class methods that have positional-only arguments</li> <li>Fixed explicit checks of PEP 604 unions against <code>types.UnionType</code> (<a href="https://redirect.github.com/agronholm/typeguard/issues/467">#467</a>)</li> <li>Fixed checks against annotations wrapped in <code>NotRequired</code> not being run unless the <code>NotRequired</code> is a forward reference (<a href="https://redirect.github.com/agronholm/typeguard/issues/454">#454</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> Sourced from <a href="https://github.com/agronholm/typeguard/blob/master/docs/versionhistory.rst">typeguard's changelog</a>. <blockquote> <h1>Version history</h1> This library adheres to <code>Semantic Versioning 2.0 <https://semver.org/#semantic-versioning-200></code>_. 4.4.1 (2024-11-03) <ul> <li>Dropped Python 3.8 support</li> <li>Changed the signature of <code>typeguard_ignore()</code> to be compatible with <code>typing.no_type_check()</code> (PR by <a href="https://github.com/jolaf"><code>@jolaf</code></a>)</li> <li>Avoid creating reference cycles when type checking uniontypes and classes</li> <li>Fixed checking of variable assignments involving tuple unpacking (<code>[#486](agronholm/typeguard#486) <https://github.com/agronholm/typeguard/issues/486></code>_)</li> <li>Fixed <code>TypeError</code> when checking a class against <code>type[Self]</code> (<code>[#481](agronholm/typeguard#481) <https://github.com/agronholm/typeguard/issues/481></code>_)</li> <li>Fixed checking of protocols on the class level (against <code>type[SomeProtocol]</code>) (<code>[#498](agronholm/typeguard#498) <https://github.com/agronholm/typeguard/issues/498></code>_)</li> <li>Fixed <code>Self</code> checks in instance/class methods that have positional-only arguments</li> <li>Fixed explicit checks of PEP 604 unions against <code>types.UnionType</code> (<code>[#467](agronholm/typeguard#467) <https://github.com/agronholm/typeguard/issues/467></code>_)</li> <li>Fixed checks against annotations wrapped in <code>NotRequired</code> not being run unless the <code>NotRequired</code> is a forward reference (<code>[#454](agronholm/typeguard#454) <https://github.com/agronholm/typeguard/issues/454></code>_)</li> </ul> 4.4.0 (2024-10-27) <ul> <li>Added proper checking for method signatures in protocol checks (<code>[#465](agronholm/typeguard#465) <https://github.com/agronholm/typeguard/pull/465></code>_)</li> <li>Fixed basic support for intersection protocols (<code>[#490](agronholm/typeguard#490) <https://github.com/agronholm/typeguard/pull/490></code>_; PR by <a href="https://github.com/antonagestam"><code>@antonagestam</code></a>)</li> <li>Fixed protocol checks running against the class of an instance and not the instance itself (this produced wrong results for non-method member checks)</li> </ul> 4.3.0 (2024-05-27) <ul> <li>Added support for checking against static protocols</li> <li>Fixed some compatibility problems when running on Python 3.13 (<code>[#460](agronholm/typeguard#460) <https://github.com/agronholm/typeguard/issues/460></code>_; PR by <a href="https://github.com/JelleZijlstra"><code>@JelleZijlstra</code></a>)</li> <li>Fixed test suite incompatibility with pytest 8.2 (<code>[#461](agronholm/typeguard#461) <https://github.com/agronholm/typeguard/issues/461></code>_)</li> <li>Fixed pytest plugin crashing on pytest version older than v7.0.0 (even if it's just present) (<code>[#343](agronholm/typeguard#343) <https://github.com/agronholm/typeguard/issues/343></code>_)</li> </ul> 4.2.1 (2023-03-24) <ul> <li>Fixed missing <code>typing_extensions</code> dependency for Python 3.12 (<code>[#444](agronholm/typeguard#444) <https://github.com/agronholm/typeguard/issues/444></code>_)</li> <li>Fixed deprecation warning in the test suite on Python 3.13 (<code>[#444](agronholm/typeguard#444) <https://github.com/agronholm/typeguard/issues/444></code>_)</li> </ul>  </blockquote> ... (truncated) </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/agronholm/typeguard/commit/cb42103a35abdfce2737d4eb58ed3d0e7f067b4a"><code>cb42103</code></a> Added release date</li> <li><a href="https://github.com/agronholm/typeguard/commit/b32af0bffb52c0b80f2c781656fb67ae1de87947"><code>b32af0b</code></a> Added tests against an empty protocol</li> <li><a href="https://github.com/agronholm/typeguard/commit/1c53caac1c98e33b113463149c01d835730a814f"><code>1c53caa</code></a> Fixed <code>pytest_ignore_collect</code> not to block default pytest code (<a href="https://redirect.github.com/agronholm/typeguard/issues/464">#464</a>)</li> <li><a href="https://github.com/agronholm/typeguard/commit/6d6b4de9940071eacbd83430b3d42207a2ac49ff"><code>6d6b4de</code></a> Fixed test_raw_uniontype_fail failing on PyPy</li> <li><a href="https://github.com/agronholm/typeguard/commit/05a677213cd6cc1f6efac4bc5ed1efcbba67da39"><code>05a6772</code></a> Fixed checks being skipped for non-forward-reference NotRequired</li> <li><a href="https://github.com/agronholm/typeguard/commit/7ff5a51d368b6d23d73c11f8f6da8d64b0c55f3a"><code>7ff5a51</code></a> Fixed issue links in the changelog</li> <li><a href="https://github.com/agronholm/typeguard/commit/b0b20c217331e299c20ab743fbb3dfa4c5eef257"><code>b0b20c2</code></a> Fixed explicit checks of PEP 604 unions against <code>types.UnionType</code></li> <li><a href="https://github.com/agronholm/typeguard/commit/0a3983039b6f8e0228ba39cb3c682c565ade19d8"><code>0a39830</code></a> Fixed <code>Self</code> checks when a method has positional-only arguments</li> <li><a href="https://github.com/agronholm/typeguard/commit/eb1e869e2c650db3d1f60a052f1426b52d3fb3cf"><code>eb1e869</code></a> Fixed reference cycles (<a href="https://redirect.github.com/agronholm/typeguard/issues/493">#493</a>)</li> <li><a href="https://github.com/agronholm/typeguard/commit/28dafeca1b39b8c19217ce09536e349c94734fa8"><code>28dafec</code></a> Fixed checking of protocols on the class level</li> <li>Additional commits viewable in <a href="https://github.com/agronholm/typeguard/compare/4.4.0...4.4.1">compare view</a></li> </ul> </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=typeguard&package-manager=pip&previous-version=4.4.0&new-version=4.4.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

antonagestam force-pushed the fix-type-check-intersection-protocols branch from ffb9c80 to 06aa3eb Compare September 21, 2024 10:54

antonagestam force-pushed the fix-type-check-intersection-protocols branch from 06aa3eb to 8614225 Compare September 21, 2024 13:41

antonagestam changed the title ~~Quickfix for intersection protocols~~ Use get_protocol_members in protocol checking Sep 21, 2024

antonagestam force-pushed the fix-type-check-intersection-protocols branch from 8614225 to 740574f Compare September 21, 2024 13:45

agronholm requested changes Sep 21, 2024

View reviewed changes

tests/test_checkers.py Outdated Show resolved Hide resolved

tests/test_checkers.py Outdated Show resolved Hide resolved

tests/test_checkers.py Outdated Show resolved Hide resolved

tests/test_checkers.py Outdated Show resolved Hide resolved

agronholm mentioned this pull request Sep 21, 2024

Protocol checking against typing_extenstion.Protocol fails #479

Closed

2 tasks

antonagestam force-pushed the fix-type-check-intersection-protocols branch from a64f3e2 to b8172ba Compare September 21, 2024 18:09

antonagestam force-pushed the fix-type-check-intersection-protocols branch from 23903cb to 42cdc09 Compare September 21, 2024 18:11

antonagestam requested a review from agronholm September 21, 2024 18:12

agronholm approved these changes Sep 21, 2024

View reviewed changes

agronholm merged commit 604b08d into agronholm:master Sep 21, 2024
10 checks passed

antonagestam deleted the fix-type-check-intersection-protocols branch September 21, 2024 18:14

thetorpedodog mentioned this pull request Sep 22, 2024

Add tests for empty protocols on built-in objects. #491

Closed

ryan-williams added a commit to single-cell-data/TileDB-SOMA that referenced this pull request Oct 18, 2024

use Typeguard@HEAD

5606b83

for agronholm/typeguard#490, for Python 3.12 tests

ryan-williams added a commit to single-cell-data/TileDB-SOMA that referenced this pull request Oct 18, 2024

use Typeguard@HEAD

79da5a6

for agronholm/typeguard#490, for Python 3.12 tests

ryan-williams added a commit to single-cell-data/TileDB-SOMA that referenced this pull request Oct 18, 2024

use Typeguard@HEAD

8c1e7ce

for agronholm/typeguard#490, for Python 3.12 tests

ryan-williams mentioned this pull request Oct 21, 2024

[python] Python 3.12 support single-cell-data/TileDB-SOMA#3001

Merged

ryan-williams mentioned this pull request Oct 21, 2024

[python] Upgrade Typeguard to >4.3.0 (once it is available) single-cell-data/TileDB-SOMA#3216

Closed

ryan-williams added a commit to single-cell-data/TileDB-SOMA that referenced this pull request Oct 21, 2024

use Typeguard@HEAD

8b45396

for agronholm/typeguard#490, for Python 3.12 tests

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use get_protocol_members in protocol checking #490

Use get_protocol_members in protocol checking #490

antonagestam commented Sep 21, 2024 •

edited

Loading

coveralls commented Sep 21, 2024 •

edited

Loading

agronholm commented Sep 21, 2024

antonagestam commented Sep 21, 2024

agronholm commented Sep 21, 2024

antonagestam commented Sep 21, 2024

agronholm commented Sep 21, 2024

agronholm left a comment

agronholm commented Sep 21, 2024

antonagestam commented Sep 21, 2024

agronholm commented Sep 21, 2024

ryan-williams commented Oct 21, 2024

agronholm commented Oct 21, 2024

agronholm commented Oct 27, 2024

Use get_protocol_members in protocol checking #490

Use get_protocol_members in protocol checking #490

Conversation

antonagestam commented Sep 21, 2024 • edited Loading

Changes

Checklist

Updating the changelog

coveralls commented Sep 21, 2024 • edited Loading

agronholm commented Sep 21, 2024

antonagestam commented Sep 21, 2024

agronholm commented Sep 21, 2024

antonagestam commented Sep 21, 2024

agronholm commented Sep 21, 2024

agronholm left a comment

Choose a reason for hiding this comment

agronholm commented Sep 21, 2024

antonagestam commented Sep 21, 2024

agronholm commented Sep 21, 2024

ryan-williams commented Oct 21, 2024

agronholm commented Oct 21, 2024

agronholm commented Oct 27, 2024

antonagestam commented Sep 21, 2024 •

edited

Loading

coveralls commented Sep 21, 2024 •

edited

Loading