Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.6, enable support for Markdown 3.4 #211

Closed
wants to merge 2 commits into from

Conversation

tomaszn
Copy link
Contributor

@tomaszn tomaszn commented Jul 31, 2023

There are incompatibilities with Markdown 3.4.

@agusmakmun Can you take a look at these?
https://github.com/Python-Markdown/markdown/blob/master/docs/change_log/release-3.4.md

I suggest releasing this as v1.7.0 (bump the minor version).

@agusmakmun
Copy link
Owner

hello @tomaszn, thank you for making this changes.. can we somehow support the python 3.6 as well?
let say, for python 3.6 will be use Markdown < 3.4, then for the higher version will use Markdown < 3.5

@DerDennisOP
Copy link

image

You need to remove the "md_globals" input parameter from every Extension Class.
Also make sure you use the .register function:
md.inlinePatterns["autolink"] = UrlizePattern(URLIZE_RE, md) -> md.inlinePatterns.register((URLIZE_RE, md), 'autolink', 100)

@DerDennisOP
Copy link

Also Python 3.6 is depricated now for almost 5 years and security support ended 1 year ago. I don't think we need Python 3.6 support

@agusmakmun
Copy link
Owner

agusmakmun commented Mar 30, 2024

Hello @tomaszn sorry for closing this PR, this fixes is alraedy in this commit:

82f9dad

https://github.com/agusmakmun/django-markdown-editor/releases/tag/v1.6.43

@agusmakmun agusmakmun closed this Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants