fix bug where pre-normalized actions are not clipped

ahalev · Jun 13, 2023 · 4506d6c · 4506d6c
1 parent 66e002a
commit 4506d6c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/pymgrid/modules/base/base_module.py b/src/pymgrid/modules/base/base_module.py
@@ -137,8 +137,12 @@ def step(self, action, normalized=True):
             this module provided to or absorbed from the microgrid.
 
         """
-
-        denormalized_action = self._action_space.denormalize(action) if normalized else action
+        if normalized:
+            denormalized_action = self._action_space.denormalize(action)
+        elif self._action_space.clip_vals:
+            denormalized_action = self._action_space.clip(action, normalized=False)
+        else:
+            denormalized_action = action
 
         try:
             denormalized_action = denormalized_action[self._energy_pos]

diff --git a/src/pymgrid/modules/genset_module.py b/src/pymgrid/modules/genset_module.py
@@ -146,6 +146,8 @@ def step(self, action, normalized=True):
         """
         if normalized:
             denormalized = self._action_space.denormalize(action)
+        elif self._action_space.clip_vals:
+            denormalized = self._action_space.clip(action, normalized=False)
         else:
             denormalized = action