Skip to content

Commit

Permalink
[test] Fix wasm2js stale check failure
Browse files Browse the repository at this point in the history
I tried to exclude wasm2js asserts tests from `check_for_stale_files` in
 WebAssembly#6164, but ended up doing it incorrectly. The file I checked for was
`wasm2js.wast.asserts`, while the output I should have excluded was
`wasm2js.asserts.js`. This fixes the code so we now check the prefix and
not the filename.

This is currently breaking the main branch, which was caused by me
landing multiple PRs at once. Sorry for the breakage. Landing this will
fix it.
  • Loading branch information
aheejin committed Dec 12, 2023
1 parent 5db8eb2 commit 0bd0115
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions scripts/test/wasm2js.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@ def check_for_stale_files():

all_files = os.listdir(shared.get_test_dir('wasm2js'))
for f in all_files:
if f in assert_tests:
continue
prefix = f.split('.')[0]
if prefix in [t.split('.')[0] for t in assert_tests]:
continue
if prefix not in all_tests:
shared.fail_with_error('orphan test output: %s' % f)

Expand Down

0 comments on commit 0bd0115

Please sign in to comment.