SimplifyLocals: Refinalize after removing redundant tees (WebAssembly…

…#5830)
aheejin · Jul 21, 2023 · 84af348 · 84af348
1 parent 794a7ee
commit 84af348
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 0 deletions.
diff --git a/src/passes/SimplifyLocals.cpp b/src/passes/SimplifyLocals.cpp
@@ -1024,6 +1024,9 @@ struct SimplifyLocals
             // This is an unnecessary copy!
             if (removeEquivalentSets) {
               if (curr->isTee()) {
+                if (curr->value->type != curr->type) {
+                  refinalize = true;
+                }
                 this->replaceCurrent(curr->value);
               } else {
                 this->replaceCurrent(Builder(*module).makeDrop(curr->value));

diff --git a/test/lit/passes/simplify-locals-gc.wast b/test/lit/passes/simplify-locals-gc.wast
@@ -517,4 +517,28 @@
       )
     )
   )
+
+  ;; CHECK:      (func $redundant-tee-finalize (type $anyref_=>_none) (param $x anyref)
+  ;; CHECK-NEXT:  (drop
+  ;; CHECK-NEXT:   (ref.cast any
+  ;; CHECK-NEXT:    (ref.cast any
+  ;; CHECK-NEXT:     (local.get $x)
+  ;; CHECK-NEXT:    )
+  ;; CHECK-NEXT:   )
+  ;; CHECK-NEXT:  )
+  ;; CHECK-NEXT: )
+  (func $redundant-tee-finalize (param $x anyref)
+    ;; The tee in the middle will be removed, as it copies a local to itself.
+    ;; After doing so, the outer cast should become non-nullable as we
+    ;; refinalize.
+    (drop
+      (ref.cast null any
+        (local.tee $x
+          (ref.cast any
+            (local.get $x)
+          )
+        )
+      )
+    )
+  )
 )