Perform additional check for no windows on Amazon Fresh #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mokudekiru Would you happen to have the source (or at least relevant element properties) for that page? I'm working on a platform-independent tool for this and haven't been able to test available slots on Amazon Fresh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amazon Fresh has a different site layout when no delivery windows are available than Whole Foods (at least in San Francisco - screenshot below). This makes the script reach an error state and results in going back to the beginning of the cart each time, losing out on 50% of potential window opportunities.
My solution is to add one last minute check after checking for windows, specifically for Amazon Fresh. If we do this earlier (alongside the first no window check) we would get false negatives when there are no delivery windows today, but there are some the following days. Not the ideal solution imo, but it avoids the unnecessary error + restart.