This repository has been archived by the owner on Oct 10, 2022. It is now read-only.
👌 IMPROVE: Styles from wp-editor with context #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avoid WordPress enqueuing additional backend css in the frontend leading to unnecessary requests
|
@asharirfan @saqibameen test this one and approve the PR so I can release a new version. |
ahmadawais
changed the title
|
Thank you! @Connum Successfully published:
|
|
Hi, would it be better to change the dependency to like This way the additional scripts are not loaded and we have a chance to overwrite the default styles for core blocks since the styles are loaded after core styles? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only add
wp-editoras block CSS dependency when in admin context, in order to avoid WordPress enqueuing additional backend CSS in the frontend leading to unnecessary requests.This addresses issue #210.