-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): support for rules & ignore sections in config #43
base: master
Are you sure you want to change the base?
Conversation
asking @ttshivers @leblancfg @AlCalzone for feedback on this breaking change, as you've all helped contribute and shape this action :) |
### Configuration file syntax | ||
### Configuration File | ||
|
||
A configuration file is **REQUIRED** to successfully determine the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incomplete sentence?
| `command` | ❌ | `merge` | The command to pass to Dependabot | | ||
| `approve` | ❌ | `true` | Auto-approve pull-requests | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these two are missing from the docs now.
Didn't look at everything in-depth, but the changes make sense IMO. Just two documentation-related nits. |
FYI: I'm holding this release back as GH Actions has showed issue with version fixing on docker based actions ... for tracking: https://github.com/github/super-linter/issues/943 |
config file now supports separate sections for ignore directives and auto-merge rules BREAKING CHANGE: - config file is now required - action inputs no longer accept target & command - config file format has changed
75b6771
to
065ebed
Compare
Hey what's the status on this? |
@ahmadnassri |
in an attempt to simplify the configuration file format and allow for additional features, this PR introduces a breaking change (and thus a major version will be released)
BREAKING CHANGE:
Before
workflow.yml
config.yml
After
workflow:yml
config.yml