atdts: Stub compiler warnings for unused parameters #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koonwen
changed the title
koonwen
requested review from
mjambon,
rgrinberg,
Khady,
zindel and
cyberhuman
as code owners
Khady
reviewed
Jul 25, 2023
Khady
reviewed
Jul 25, 2023
doc/atdts.rst
Outdated
Comment on lines
368
to
371
| Caveats | ||
| ========= | ||
| * Generated typescript contains a flag telling the compiler not to run | ||
| checks on the file. |
There was a problem hiding this comment.
could link to #347 to give some context
Khady
approved these changes
Jul 28, 2023
mjambon
added a commit
to mjambon/opam-repository
that referenced
this pull request
Oct 16, 2023
CHANGES: * atdts: Stop compiler errors on generated typescript (ahrefs/atd#348) * atdts: Don't fail on `wrap` constructs (ahrefs/atd#353) * atdcat: New option `-remove-wraps` which pretty-prints the type definitions without `wrap` constructs (ahrefs/atd#353) * atdd: Add `dlang` backend to generate D code from ATD definitions (ahrefs/atd#349) * new tool: atddiff. Compares two versions of an ATD file and reports possible incompatibilities in the JSON data. Atddiff ships as part of the `atd` package together with `atdcat` (ahrefs/atd#352, ahrefs/atd#358)
nberth
pushed a commit
to nberth/opam-repository
that referenced
this pull request
Jun 18, 2024
CHANGES: * atdts: Stop compiler errors on generated typescript (ahrefs/atd#348) * atdts: Don't fail on `wrap` constructs (ahrefs/atd#353) * atdcat: New option `-remove-wraps` which pretty-prints the type definitions without `wrap` constructs (ahrefs/atd#353) * atdd: Add `dlang` backend to generate D code from ATD definitions (ahrefs/atd#349) * new tool: atddiff. Compares two versions of an ATD file and reports possible incompatibilities in the JSON data. Atddiff ships as part of the `atd` package together with `atdcat` (ahrefs/atd#352, ahrefs/atd#358)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the quick fix mentioned in issue 347
PR checklist
CHANGES.mdis up-to-date