filter local endpoints when set remote

[gojoy]

some etcd member has multiple clientURLs inculde local address,for example:
["http://10.7.7.7:2379","http://127.0.0.1:2379"]
in this case, excuting etcd-defrag with --cluster on remote machine would fail,because health check failed.
we should add flag --remote to filter local address

[ahrtr]

Thanks @gojoy for raising this PR. Overall it makes sense to me. Please resolve the two comments above.

[gojoy]

Thanks @gojoy for raising this PR. Overall it makes sense to me. Please resolve the two comments above.

got it

[ahrtr]

Please also verify IPv6 loopback address in the test cases.

[gojoy]

Please also verify IPv6 loopback address in the test cases.

done

[gojoy]

Hi. Is there any problem that I should solve ? 😄 @ahrtr

[ahrtr]

Hi. Is there any problem that I should solve ? 😄 @ahrtr

Please read #52 (comment). I remaindered you a couple of times, I am not sure why you keep marking it as resolved but actually not resolving it.

[gojoy]

Hi. Is there any problem that I should solve ? 😄 @ahrtr

Please read #52 (comment). I remaindered you a couple of times, I am not sure why you keep marking it as resolved but actually not resolving it.

Sorry I misunderstood your meaning before. I didn't ignore it on purpose.
net.ParseIP cannot parse localhost and http:// url like http://127.0.0.1:2379,127.0.0.1:2379. So using ip.IsLoopback() cannot work well.

[ahrtr]

net.ParseIP cannot parse localhost and http:// url like http://127.0.0.1:2379,127.0.0.1:2379. So using ip.IsLoopback() cannot work well.

The point is try not to hardcode the loopback address, and instead make it flexible. You can try to get the host part from the URL firstly, afterwards check whether or not it's a loopback address.

[gojoy]

net.ParseIP cannot parse localhost and http:// url like http://127.0.0.1:2379,127.0.0.1:2379. So using ip.IsLoopback() cannot work well.

The point is try not to hardcode the loopback address, and instead make it flexible. You can try to get the host part from the URL firstly, afterwards check whether or not it's a loopback address.

I agree. I adjusted the code to make it flexible.thanks

[ahrtr]

Thanks for all the effort. I will merge this PR once the above minor comments are resolved.