Support Pusher and Reader for unordered_map with Hash param
#12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* If a `Hash` template parameter is used when constructing a `std::unordered_map` (which is required for `boost::variant` keys), then the `Pusher` and `Reader` template parameter deduction fails, and we revert to assuming a simple `userdata` pointer. * This means we cannot read and write std::unordered_map`s as lua tables. * So simply add a `Hasher` template param to the `Pusher` and `Reader` for `std::unordered_map`.
|
Want to write a test for this? If you rebase onto master, the testing framework is no longer broken, and Travis will test your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hashtemplate parameter is used when constructing astd::unordered_map(which is required forboost::variantkeys), thenthe
PusherandReadertemplate parameter deduction fails, and werevert to assuming a simple
userdatapointer.std::unordered_mapthat hasboost::variantkeys as a Luatable.
Hashertemplate param to thePusherandReaderfor
std::unordered_map.