Fixed bug that confuses lua_next. #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the manual: > If the value is a number, then lua_tolstring also changes the actual > value in the stack to a string. (This change confuses lua_next when > lua_tolstring is applied to keys during a table traversal.) That leads to potential problems while reading keys that are boost::variant.
|
Any reason to not merge this PR? Is this project abandoned? |
|
@verri hi! this project is not abandoned, but we don't always find time to maintain it. I'll try to do a cleanup round soon. Apologies for the wait! |
Habbie
added a commit
to Habbie/pdns
that referenced
this pull request
Mar 17, 2020
Habbie
added a commit
to Habbie/pdns
that referenced
this pull request
Mar 18, 2020
Habbie
added a commit
to Habbie/pdns
that referenced
this pull request
Mar 11, 2021
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the problem that I mentioned in #37.
According to the manual:
That leads to potential problems while reading maps which keys are
std::string or boost::variant<std::string, ...> and the lua table key is numeric.
If you decide to merge one of these PRs, I can rebase the other one.
Just let me know.