wrap simple function pointers #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Habbie
commented
Sep 18, 2019
| @@ -2272,16 +2272,24 @@ struct LuaContext::Pusher<TReturnType (TParameters...)> | |||
| // when the lua script calls the thing we will push on the stack, we want "fn" to be executed | |||
| // since "fn" doesn't need to be destroyed, we simply push it on the stack | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
| // we wrap the function pointer so we can store it in a userdata |
Habbie
commented
Sep 18, 2019
| lua_pushlightuserdata(state, reinterpret_cast<void*>(fn)); | ||
| // we make a userdata to hold the function's address | ||
| auto wrapper = (struct wrap *) lua_newuserdata(state, sizeof(void*)); | ||
|
|
There was a problem hiding this comment.
Suggested change
| // and we store the function pointer inside it |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the usage of lightuserdata, which in turn avoids crashes in LuaJIT on many Linux/ARM64 setups.