Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

154 as an inpector i want to store all registration numbers #214

Conversation

Francois-Werbrouck
Copy link
Contributor

ref #154

@Francois-Werbrouck Francois-Werbrouck linked an issue Nov 11, 2024 that may be closed by this pull request
@Francois-Werbrouck Francois-Werbrouck marked this pull request as ready for review November 11, 2024 21:07
@Francois-Werbrouck Francois-Werbrouck requested review from a team as code owners November 11, 2024 21:07
@Francois-Werbrouck Francois-Werbrouck force-pushed the 154-as-an-inpector-i-want-to-store-all-registration-numbers branch from 8ca4150 to b9ee886 Compare November 13, 2024 21:14
@k-allagbe
Copy link
Member

Please, let's pause this until we hear from the client.

@Francois-Werbrouck
Copy link
Contributor Author

Francois-Werbrouck commented Nov 18, 2024

It is finished. We need to confirm the following with the client:

I'd like to clear out some behavior on the application regarding the record keeping and would like your inputs (this is mostly for the FE)

  1. Register inspection
  • The datastore do not expect to receive a value from the pipeline the record keeping value (this is until the pipeline can output something)
  • The datastore saves the record keeping value as NULL since we have no way of knowing
  1. Inspector validate an Inspection
  • The datastore returns the value saved for the record keeping (default is null, meaning we have no idea if it is or it isnt)
    • record_keeping = Null -> Display the ingredients
    • record_keeping = True ->
      • The inspector has already confirmed it was a record keeping and cameback on the form where there are the record keeping option, therefore it needs to be displayed as checked [ ]
      • The inspector has already confirmed it was a record keeping and open the ingredients of the form. DO WE STILL DISPLAY THE INGREDIENT (Guaranteed analysis)?
    • record_keeping = False -> The inspector has not checked (clicked) the option for record keeping, therefore we display all the ingredients
  1. A user wants to see a validated inspection
  • record_keeping = True -> We do not display the ingredients (if any were picked up by the pipeline), but display a text stating it is a record keeping fertilizer
  • record_keeping = False -> We display the ingredients as it was done previously and we do not display the record_keeping boolean ???

Other than the behaviors, the registration numbers architecture now allow to save and display a list picked up (or not detected) by the pipeline

@Francois-Werbrouck Francois-Werbrouck merged commit 2070dac into main Nov 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As an Inpector, I want to store all registration numbers
2 participants