4-adding-workflows #5
Conversation
ghost
requested a review
from 
ghost
self-assigned this
ghost
added
the
documentation
GitHub Codespaces
|
the workflow should be running in this pull request. If you look at the Actions logs, you can see there is a problem with the workflow itself: https://github.com/ai-cfia/nachet-metadata-format/actions/runs/7831834689 |
|
I've figure the issue (Action secrets are missing) and will try to solve it by adding the secrets needed |
|
Check the Actions tab of the repository for details on why the workflows do not startup:
|
|
The workflows are now running, however the yaml-check seems to not be working properly. I will need to investigate |
There was a problem hiding this comment.
I see there's a couple of trailing spaces and such that need fixing.
For line length, @ThomasCardin and @SonOfLope modified the rules to allow longer lines and a number of other tweaks:
https://github.com/ai-cfia/howard/blob/main/.yamllint.yml
instead of doing per repo, I'd rather we have unified rules in ai-cfia/github-workflows for all.
I will create an issue to support this. Currently we can only specify a config file from the calling repository. We can discuss the proper solution in that issue. |
Yes, implicitly I'm asking for a new issue. Also suggest you use "Reference in new issue" so we have context for that new issue (and a bidirectional link so we know that there's a follow up):
|
I had already created an issue and pull request. Noted for next time. |
|
@FrancoisWerbrouck-CFIA the now working checks are reporting some deviation from standards; please fix. Ensure that your IDE is setup to catch these issues before they are pushed to the repository. |
|
@FrancoisWerbrouck-CFIA omitting a config file for the yaml linting workflow should now allow to make use of the default config from github-workflow repository. |
|
I made all the workflows run and complete their default checks. I will add specifics tests in others PR. The core of the issue #3 as been completed, which was adding the workflows to the current Repo |
tests/testing_utils.py
Outdated
| @@ -3,5 +3,5 @@ | |||
| def raise_error(message): | |||
| raise Exception(message) | |||
There was a problem hiding this comment.
Instead of Exception, I suggest that you use a custom Exception:
# On top of the file, or in an exception module
EnvironmentVariableError(Exception):
pass
# Of course use the class name that you feel is best for your project
# Then:
NACHET_SCHEMA = os.getenv("NACHET_SCHEMA") or raise EnvironmentVariableError("NACHET_SCHEMA is not set")
|
I'm having issue with the secrets in the Action phase. The testing works I'll talk with the devops guys since they just release some doc about secrets handling |
|
Failing pipeline will be fixed with ai-cfia/github-workflows#110 |
|
Pipeline for linting python test is fixed as we can see with checks |
Francois-Werbrouck
force-pushed
the
4-adding-workflows
branch
from
51a019f to
da68557
Compare
Done, I will now merge the branch and rebase my other branches on main |
Adding ai-cfia Workflows to the current branch to comply with our internal standard