-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue #32: added every useful workflows #33
issue #32: added every useful workflows #33
Conversation
Hey @k-allagbe, I see that this repository doesn't have a description. Could you add one please? Also, for the test, do you have any idea what is the error? |
Done. |
@k-allagbe Hey, I wanted to inform you that I've pushed a .vscode folder. It includes extensions and settings to ensure that GitHub actions pass (with a maximum of 80 characters per line for .md files). Additionally, if you have any extensions that you use for this project and keep locally, feel free to add them to the files .vscode/extensions.json or .vscode/settings.json. This will enable the next developer joining the project to have everything they need to start development as quickly as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Note that I added the extensions to the devcontainer config.
@ThomasCardin not sure why this https://github.com/ai-cfia/finesse-backend/actions/runs/7631368304/job/20789157763?pr=33. There is a |
Yes, I believe the workflow is checking out the main branch and not this one. In reality, it's not a problem that it checks out the main branch because there should be a TESTING.md by default when creating a directory in the future. Anyway, you can ignore the error for this PR. |
@ThomasCardin |
@rngadam ping (workflows are fixed) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please consider one last suggestion made for naming
Workflow included: