Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #32: added every useful workflows #33

Merged
merged 9 commits into from
Jan 26, 2024

Conversation

ThomasCardin
Copy link
Member

@ThomasCardin ThomasCardin commented Jan 22, 2024

Workflow included:

  • Lint test
  • Markdown validation
  • ai-cfia repo standard
  • build and push to github container registry (GCR)

@ThomasCardin ThomasCardin linked an issue Jan 22, 2024 that may be closed by this pull request
@ThomasCardin ThomasCardin requested a review from rngadam January 22, 2024 20:12
@ThomasCardin
Copy link
Member Author

Hey @k-allagbe, I see that this repository doesn't have a description. Could you add one please? Also, for the test, do you have any idea what is the error?

@ThomasCardin ThomasCardin marked this pull request as draft January 22, 2024 20:22
@k-allagbe
Copy link
Member

Hey @k-allagbe, I see that this repository doesn't have a description. Could you add one please? Also, for the test, do you have any idea what is the error?

Done.

@ThomasCardin
Copy link
Member Author

@k-allagbe Hey, I wanted to inform you that I've pushed a .vscode folder. It includes extensions and settings to ensure that GitHub actions pass (with a maximum of 80 characters per line for .md files). Additionally, if you have any extensions that you use for this project and keep locally, feel free to add them to the files .vscode/extensions.json or .vscode/settings.json. This will enable the next developer joining the project to have everything they need to start development as quickly as possible.

Copy link
Member

@k-allagbe k-allagbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Note that I added the extensions to the devcontainer config.

@k-allagbe
Copy link
Member

@ThomasCardin ThomasCardin marked this pull request as ready for review January 23, 2024 20:32
@rngadam rngadam changed the title issue #32: added every usefull workflows issue #32: added every useful workflows Jan 23, 2024
@ThomasCardin
Copy link
Member Author

@ThomasCardin not sure why this https://github.com/ai-cfia/finesse-backend/actions/runs/7631368304/job/20789157763?pr=33. There is a TESTING.md file.

Yes, I believe the workflow is checking out the main branch and not this one. In reality, it's not a problem that it checks out the main branch because there should be a TESTING.md by default when creating a directory in the future.

Anyway, you can ignore the error for this PR.

@ThomasCardin ThomasCardin self-assigned this Jan 23, 2024
@rngadam
Copy link

rngadam commented Jan 23, 2024

Yes, I believe the workflow is checking out the main branch and not this one. In reality, it's not a problem that it checks out the main branch because there should be a TESTING.md by default when creating a directory in the future.

@ThomasCardin
as discussed, Github Workflows check should be done on the current branch to give an opportunity to the developer to fix it and only fix for repos that are under active development.

@ThomasCardin
Copy link
Member Author

@rngadam ping (workflows are fixed)

Copy link

@rngadam rngadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please consider one last suggestion made for naming

.github/workflows/github-workflows.yml Outdated Show resolved Hide resolved
@ThomasCardin ThomasCardin merged commit e075c63 into main Jan 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix every workflow inside this repository
3 participants