Feature/coarse grain c384 diagnostic data #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnaKwa
reviewed
Jan 30, 2020
nbren12
changed the title
AnnaKwa
reviewed
Jan 31, 2020
brianhenn
requested changes
Jan 31, 2020
brianhenn
reviewed
Jan 31, 2020
There was a problem hiding this comment.
Thanks @AnnaKwa -- the cftime issues caught my eye.
I also agree with @brianhenn that it would be great to generalize the script for coarsening the diagnostics at some point. I'm not sure if we want to do that now or not. It sounds like @nbren12 thought it might be a good idea to process the all the diagnostics as part of this PR, but obviously that would make this a little more involved.
brianhenn
reviewed
Feb 1, 2020
|
Thanks for the comments @spencerkclark and @brianhenn, this is ready for re-review. |
spencerkclark
approved these changes
Feb 4, 2020
brianhenn
approved these changes
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AnnaKwa Here is the code I wrote to do some to load the C384 data and then coarse-grain it. It's based off of a notebook by @brianhenn. Maybe it would be useful to save the fully reduced data as part of this PR.