No longer force unwrap footer result #41
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid force unwrapping here. I ended up using
UnwrappedResults()
erroneously to match the existing signature([]byte, error)
overResults()
which would more safely return(*[]byte, error)
. The existing signature is the way it is because[]byte
can have anil
state, which isn't expressible at a generic level.Add some special casing to transform the
Option[[]byte]
into[]byte
by mapping theNone
case tonil == []byte{}
.