Skip to content

Commit

Permalink
change(pypi): use the python package version instead of sha in repo n…
Browse files Browse the repository at this point in the history
…ames

Initially the repo name generate was very conservative and we had sha256
as the endings of the repo names. With this change we have more human
readable repository names. In order to still comply with the bazel label
rules, we are normalizing the versions to only have `_` and `.`
characters.

This is an alternative fix to the error message seen in
bazelbuild#1837 (comment)
  • Loading branch information
aignas committed Nov 1, 2024
1 parent b6fc2a0 commit cfd70f5
Show file tree
Hide file tree
Showing 5 changed files with 1,896 additions and 1,902 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ A brief description of the categories of changes:
by default. Users wishing to keep this argument and to enforce more hermetic
builds can do so by passing the argument in
[`pip.parse#extra_pip_args`](https://rules-python.readthedocs.io/en/latest/api/rules_python/python/extensions/pip.html#pip.parse.extra_pip_args)
* (pypi, bzlmod) Change the repo naming when `experimental_index_url` is enabled
to include the version number in the external repository names.

{#v0-0-0-fixed}
### Fixed
Expand Down
Loading

0 comments on commit cfd70f5

Please sign in to comment.