Skip to content

Commit

Permalink
Minor changes to address PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
sphuber committed Nov 15, 2018
1 parent f67bcdf commit 24e73a3
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions aiida/orm/node/process/calculation/calcjob.py
Original file line number Diff line number Diff line change
Expand Up @@ -1591,9 +1591,9 @@ def _get_calculation_info_row(cls, res, projections, times_since=None):
calculation_class = get_plugin_type_from_type_string(calculation_type)
module, class_name = calculation_class.rsplit('.', 1)

# For the base class 'calculation.job.CalcJobNode' the module at this point equals 'calculation.job'
# For this case we should simply set the type to the base module calculation.job. Otherwise we need
# to strip the prefix to get the proper sub module
# For the base class 'mode.process.calculation.calcjob.CalcJobNode' the module at this point equals
# 'node.process.calculation.calcjob'. For this case we should simply set the type to the base module
# 'node.process.calculation.calcjob. Otherwise we need to strip the prefix to get the proper sub module
if module == prefix.rstrip('.'):
d['calculation']['type'] = module[len(prefix):]
else:
Expand Down Expand Up @@ -1912,7 +1912,7 @@ def _presubmit(self, folder, use_unstored_links=False):
# I create the job template to pass to the scheduler
job_tmpl = JobTemplate()
job_tmpl.shebang = computer.get_shebang()
## TODO: in the future, allow to customize the following variables
# TODO: in the future, allow to customize the following variables
job_tmpl.submit_as_hold = False
job_tmpl.rerunnable = False
job_tmpl.job_environment = {}
Expand Down Expand Up @@ -2156,8 +2156,8 @@ def submit_test(self, folder=None, subfolder_name=None):
else:
subfolder_basename = subfolder_name

## Find a new subfolder.
## I do not user tempfile.mkdtemp, because it puts random characters
# Find a new subfolder.
# I do not user tempfile.mkdtemp, because it puts random characters
# at the end of the directory name, therefore making difficult to
# understand the order in which directories where stored
counter = 0
Expand Down

0 comments on commit 24e73a3

Please sign in to comment.