Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated parser test discovery for installed plugins #1091

Closed
sphuber opened this issue Jan 31, 2018 · 2 comments · Fixed by #2778
Closed

Automated parser test discovery for installed plugins #1091

sphuber opened this issue Jan 31, 2018 · 2 comments · Fixed by #2778
Assignees
Labels
priority/quality-of-life would simplify development topic/plugin-system topic/testing type/question may redirect to mailinglist
Milestone

Comments

@sphuber
Copy link
Contributor

sphuber commented Jan 31, 2018

I implemented an addition to the PwParser of the aiida-quantumespresso and wanted to write some tests for this as well. I found a folder parser_tests in the tests folder of the plugin repository and subsequently found in the developers documentation that these used to live in aiida-core in the path aiida.backends.tests.parser_tests and the test class in aiida.backends.tests.parsers would know how to read the content of those directories and automatically run a standard test. Since the tests were moved to the aiida-quantumespresso package, the verdi devel tests db.parsers command now runs zero tests. I guess the functionality to discover parser tests through the plugin system has not yet been implemented? Is this the case? I remember that we released v0.11.1 this month because it contained new functionality regarding the testing of plugins. Was this not included?

@sphuber sphuber added type/question may redirect to mailinglist topic/testing topic/plugin-system priority/quality-of-life would simplify development labels Jan 31, 2018
@sphuber sphuber added this to the v0.12.0 milestone Jan 31, 2018
@ltalirz
Copy link
Member

ltalirz commented Feb 26, 2018

What we added in v0.11.1 is plugin fixtures that take away the task to setup & destroy test-profiles and -databases (which makes it much easier for plugin developers to write tests).

I think your question is a question for @DropD

@DropD DropD removed their assignment Aug 28, 2018
@giovannipizzi giovannipizzi modified the milestones: v1.0.0, v1.1.0 Dec 3, 2018
@sphuber
Copy link
Contributor Author

sphuber commented Apr 14, 2019

Pinging @giovannipizzi I just checked into this issue again and realized that currently the aiida.backends.tests.test_parsers is never even being run, because it is (unintentionally) being shadowed by aiida.backends.tests.parsers.test_parser. Is this still being used by anyone? I am not even sure anymore how this was triggered and how one could extend it from a plugin. Was this ever possible? If not, maybe we can remove it as with the pytest approach and fixtures, I think we have a better alternative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/quality-of-life would simplify development topic/plugin-system topic/testing type/question may redirect to mailinglist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants