Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aiida_tests entry point group and parser_tests #2778

Merged

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Apr 17, 2019

Fixes #1091

The aiida_tests entry point was added as a temporary replacement until
the plugin test fixtures came available. These have been available for a
while now and since no plugins rely on the entry point group we remove
it. Additionally, the test_parsers was a first implementation to test
parser plugins, but this can be done more elegantly with pytest and
the plugin fixtures, therefore it is removed.

@sphuber sphuber requested a review from giovannipizzi April 17, 2019 17:19
@sphuber
Copy link
Contributor Author

sphuber commented Apr 17, 2019

Note, I have gone through all the plugins on the registry and looked at their setup.json and none of them use the aiida.tests entry point group except for aiida-nwchem and aiida-castep. The former we control and we can easily migrate to use pytest with the fixtures. @zhubonan are you still relying on the aiida.tests entry point, which contains one test for the CastepCalculation or have you also migrated to using pytests?

@sphuber sphuber force-pushed the fix_1091_parsers_tests_entry_point branch from d663a66 to 120a57a Compare April 17, 2019 17:22
@coveralls
Copy link

coveralls commented Apr 17, 2019

Coverage Status

Coverage decreased (-0.04%) to 71.623% when pulling d0ac414 on sphuber:fix_1091_parsers_tests_entry_point into 5c17bda on aiidateam:develop.

@zhubonan
Copy link
Contributor

zhubonan commented Apr 17, 2019 via email

The `aiida_tests` entry point was added as a temporary replacement until
the plugin test fixtures came available. These have been available for a
while now and since no plugins rely on the entry point group we remove
it. Additionally, the `test_parsers` was a first implementation to test
parser plugins, but this can be done more elegantly with `pytest` and
the plugin fixtures, therefore it is removed.
@sphuber sphuber force-pushed the fix_1091_parsers_tests_entry_point branch from 120a57a to d0ac414 Compare April 18, 2019 06:19
@sphuber sphuber merged commit 39989d8 into aiidateam:develop Apr 18, 2019
@sphuber sphuber deleted the fix_1091_parsers_tests_entry_point branch April 18, 2019 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automated parser test discovery for installed plugins
4 participants