Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify export file format after JSONB migration is performed #2815

Closed
giovannipizzi opened this issue May 1, 2019 · 1 comment · Fixed by #3090
Closed

Simplify export file format after JSONB migration is performed #2815

giovannipizzi opened this issue May 1, 2019 · 1 comment · Fixed by #3090
Assignees
Labels
priority/nice-to-have priority/quality-of-life would simplify development topic/archive type/performance Issue related to how quickly AiiDA works
Milestone

Comments

@giovannipizzi
Copy link
Member

Currently there is a convoluted way of storing datetimes in the export file, to mark them as date times and not as strings (the attributes dictionary is "duplicated", having None values in every place that maps a standard data type, except for value related a date time, where a special string is used). This is the node_attributes_conversion field, see docs

If in #2788 we remove support for datetimes, we can safely remove this dictionary from the data.json - this will reduce the export file size, simplify the code and most probably also make import/export faster.

@CasperWA
Copy link
Contributor

CasperWA commented May 1, 2019

We need to make sure that node_attributes_conversion is used only for datetime objects.

When removing node_attributes_conversion, the newly added node_extras_conversion dict can also be removed from the export files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/nice-to-have priority/quality-of-life would simplify development topic/archive type/performance Issue related to how quickly AiiDA works
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants