Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the export version to v0.6 #3056

Closed
sphuber opened this issue Jun 20, 2019 · 3 comments · Fixed by #3090
Closed

Update the export version to v0.6 #3056

sphuber opened this issue Jun 20, 2019 · 3 comments · Fixed by #3090
Assignees
Labels
Milestone

Comments

@sphuber
Copy link
Contributor

sphuber commented Jun 20, 2019

This should take care of a few things:

  • Simplify the schema due to the migration of Django to JSONB for the attributes and extras by removing the data serialization dictionaries. This was only used for datetime objects and since they are no longer supported, the whole concept can and should be removed.
  • Convert datetime objects from attributes and extras to isoformat strings, they are no longer supported
  • Apply the data migration for old JobCalculation nodes that will be handled in Add data migration for old calculation jobs #2854
@CasperWA
Copy link
Contributor

CasperWA commented Jun 23, 2019

This is essentially an "umbrella" issue for:

Furthermore, it should be noted that whenever the export version is upped, migration functions must be made (even if it is to just up the version number in the migrated archive) and tests for it, possibly including a new archive for aiida-export-migration-tests.

Finally, it should be noted that this may even be affected further by issue #1762.
However, this issue could also be resolved later by upping the export version again (to v0.7)-

@sphuber sphuber self-assigned this Jun 24, 2019
@CasperWA
Copy link
Contributor

I believe this issue can be closed now, correct @sphuber?

@sphuber
Copy link
Contributor Author

sphuber commented Jun 28, 2019

Correct, this was fixed in PR #3090

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants