Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate coverage to CI when testing is migrated to pytest #3602

Closed
CasperWA opened this issue Dec 4, 2019 · 4 comments
Closed

Reinstate coverage to CI when testing is migrated to pytest #3602

CasperWA opened this issue Dec 4, 2019 · 4 comments

Comments

@CasperWA
Copy link
Contributor

CasperWA commented Dec 4, 2019

@sphuber Is it correctly understood that coverage/codecov has disappeared in the process of moving to GitHub Actions?

@sphuber
Copy link
Contributor

sphuber commented Dec 4, 2019

Yes as mentioned in PR #3571 I omitted it on purpose. It was often buggy so we did not actually pay any attention to what it was saying. We put a big threshold on it just to prevent it from giving false positives. In addition, it was not even correctly registering all paths we were running. The move to pytest will allow us to run pytest-cov which should fix it. Maybe we look into it then again

@CasperWA
Copy link
Contributor Author

CasperWA commented Dec 4, 2019

Cool. I'll just put in a link to codecov-action here for the future implementation of this.
There is also a coveralls gh-action.

@sphuber sphuber changed the title coverage is gone? Reinstate coverage to CI when testing is migrated to pytest Dec 4, 2019
@ltalirz
Copy link
Member

ltalirz commented Dec 5, 2019

we might actually want to give it a try even before - if the information is usable, then it could be very helpful for improving test coverage for the "data/tools" commands during the coding week.

@CasperWA
Copy link
Contributor Author

CasperWA commented Dec 9, 2019

From short discussion at the coding week 2019 between @dev-zero, @giovannipizzi, and me:

  • Move to codecov.
  • Create GH Actions job to run on pushes to master and develop branches (on aiidateam/aiida-core) and for all PRs.
  • Make sure to properly exclude test files and folders, and consider which other files/folders should be excluded.

dev-zero added a commit to dev-zero/aiida-core that referenced this issue Dec 9, 2019
CasperWA pushed a commit to dev-zero/aiida-core that referenced this issue Feb 6, 2020
ltalirz pushed a commit to dev-zero/aiida-core that referenced this issue Mar 3, 2020
@sphuber sphuber added this to the v1.1.2 milestone Mar 3, 2020
@sphuber sphuber modified the milestones: v1.1.2, v1.2.0 Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants