Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace tests.utils.configuration with the corresponding pytest fixtures #4249

Closed
sphuber opened this issue Jul 10, 2020 · 0 comments · Fixed by #5500
Closed

Replace tests.utils.configuration with the corresponding pytest fixtures #4249

sphuber opened this issue Jul 10, 2020 · 0 comments · Fixed by #5500
Assignees
@sphuber
Labels
priority/quality-of-life would simplify development topic/config topic/testing type/refactoring

Comments

@sphuber
Copy link
Contributor

sphuber commented Jul 10, 2020

This will require the tests that use these old utils to first be converted to normal tests, but that is anyway the plan
@sphuber sphuber self-assigned this Jul 10, 2020
@sphuber sphuber added priority/quality-of-life would simplify development and removed priority/nice-to-have labels Jul 10, 2020
@sphuber sphuber mentioned this issue Jul 10, 2020
Closed
chrisjsewell added a commit to chrisjsewell/aiida_core that referenced this issue Feb 18, 2021
@chrisjsewell
🧪 TESTS: add config_with_profile fixture
3c5f3d6 
Partially addresses aiidateam#4249,
removing `temporary_config_instance` and `with_temporary_config_instance` from `tests/utils/configuration.py`
@chrisjsewell chrisjsewell mentioned this issue Feb 18, 2021
Merged
@sphuber sphuber mentioned this issue Apr 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sphuber sphuber

Labels
priority/quality-of-life would simplify development topic/config topic/testing type/refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove legacy tests/utils/configuration.py sphuber/aiida-core
1 participant
@sphuber